Project

General

Profile

Actions

Bug #15525

closed
JP JP

File browser on ``diag_edit.php`` does not encode directory names before display

Bug #15525: File browser on ``diag_edit.php`` does not encode directory names before display

Added by Jim Pingle over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Diagnostics
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
24.11
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

The file browser on diag_edit.php does not encode directory names before display

Similar to #13262 which fixed problematic filenames, but directories can also trigger a similar issue both in the file/directory list and in the breadcrumb/directory path line.

Creating a directory named \'\>\"\>\<img\ src=q\ onerror=alert\(\'xss\'\)\;\> and then browsing to it will produce a JS alert.

A user who can create directories with arbitrary names can break rendering of the page though exploit potential is minimized by the fact that `/` is not valid in directory names so tags cannot be closed.

JP Updated by Jim Pingle over 2 years ago Actions #2

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:33f2ad2414b8a1246d511523b4ec0b67bbb224da.

GT Updated by Georgiy Tyutyunnik over 2 years ago Actions #3

tested on:
24.03-RELEASE (amd64)
built on Wed Apr 24 17:38:00 UTC 2024
FreeBSD 15.0-CURRENT
patch fixes the issue

JP Updated by Jim Pingle over 2 years ago Actions #4

  • Status changed from Feedback to Resolved

JP Updated by Jim Pingle almost 2 years ago Actions #5

  • Plus Target Version changed from 24.08 to 24.11

JP Updated by Jim Pingle almost 2 years ago Actions #6

  • Private changed from Yes to No
Actions

Also available in: Atom