Todo #15782: Use minified nvd3 vendor files - pfSense - pfSense bugtracker

Actions

Copy link

Todo #15782

closed

Use minified nvd3 vendor files

Added by GChuf 6 about 1 month ago. Updated about 1 month ago.

Status:

Resolved

Priority:

Normal

Assignee:

Marcos M

Category:

Web Interface

Target version:

2.8.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

24.11

Release Notes:

Default

Description

PR: https://github.com/pfsense/pfsense/pull/4707

Creating another issue as suggested.
I wasn't sure if the PR/issue would be considered as I know you're careful with updating vendor files.

The files are readily available in the github release, so hashing/auditing should not be too difficult:
https://github.com/novus/nvd3/releases/tag/v1.8.6

I copied the files directly and tested the change in v2.7.2.

Actions

Copy link

Updated by GChuf 6 about 1 month ago

This issue can be closed now as v1.8.6 is already included: https://redmine.pfsense.org/issues/14190

Actions

Copy link

Updated by GChuf 6 about 1 month ago

Additionally - the minified files now produce a "source map error" in the browser console:

Source map error: request failed with status 404
Resource URL: https://192.168.16.1/vendor/nvd3/nv.d3.js?v=1728938343
Source Map URL: nv.d3.min.js.map

This can be solved with adding map files, or commenting out the sourceMappingURL comments.

Actions

Copy link