Project

General

Profile

Actions
Copy link

Bug #15927

closed

Potential XSS in AutoConfigBackup backup list on ``services_acb.php``

Bug #15927: Potential XSS in AutoConfigBackup backup list on ``services_acb.php``

Added by Jim Pingle over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
Jim Pingle
Category:
Auto Configuration Backup
Target version:
2.8.0
Start date:
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
25.07
Release Notes:
Default
Affected Version:
Affected Architecture:

Description

The page at ``services_acb.php`` displays the "reason" string when listing backup entries from the server without encoding, which is a potential XSS vector.

The reason string for a backup entry is encoding when stored, but this encoding happens client-side so it may not always happen as expected. The page should escape the string before display to avoid any potential problems.

Updated by Jim Pingle over 1 year ago Actions
Copy link
 #1

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:84d8eddf87607e0f9dcc313bcaad4db67e4f3750.

Updated by Christopher Cope over 1 year ago Actions
Copy link
 #3

  • Status changed from Feedback to Closed

Tested on

25.03-DEVELOPMENT (amd64)
built on Fri Dec 13 6:00:00 UTC 2024
FreeBSD 15.0-CURRENT

The fix is applied and the reason string is escaped. Marking as resolved.

Updated by Jim Pingle over 1 year ago Actions
Copy link
 #4

  • Status changed from Closed to Feedback

Still need to wait for feedback from the original reporter to be sure it's solved on their side before completely closing.

Updated by Jim Pingle over 1 year ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved

Updated by Jim Pingle over 1 year ago Actions
Copy link
 #6

  • Private changed from Yes to No

Updated by Jim Pingle about 1 year ago Actions
Copy link
 #7

  • Plus Target Version changed from 25.03 to 25.07
Actions
Copy link

Also available in: Atom