Project

General

Profile

Feature #1603

URL table aliases should be usable within network type aliases

Added by Chris Buechler about 8 years ago. Updated about 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Rules/NAT
Target version:
-
Start date:
06/15/2011
Due date:
% Done:

0%

Estimated time:

Description

It would be nice to be able to specify multiple URL table aliases within one network type alias. For instance I just setup a firewall that blocks a few countries using URL Table aliases, being able to add those to a "BlockedCountries" alias instead would make the ruleset a lot smaller. Input validation currently rejects this.

Associated revisions

Revision 5ffa3389 (diff)
Added by Ermal Luçi almost 8 years ago

Feature #1603. Correct nested urltable alias code to be more fullproof to errors and does not break the ruleset on large lists of urltables. Though this needs a revisit to work properly since it breaks urltable alias property of reloading contents.

Revision 3a26fb7f (diff)
Added by Ermal Luçi almost 8 years ago

Feature #1603. Correct nested urltable alias code to be more fullproof to errors and does not break the ruleset on large lists of urltables. Though this needs a revisit to work properly since it breaks urltable alias property of reloading contents.

History

#2 Updated by Chris Buechler almost 8 years ago

  • Status changed from New to Feedback

Evgeny - this is ok but in the future please don't commit anything with a target 2.1 to 2.0.

#3 Updated by Evgeny Yurchenko almost 8 years ago

I am sorry, did not pay attention to target version, just felt that it was doable.

#4 Updated by Ermal Luçi almost 8 years ago

  • Affected Version set to 2.0

This is probably broken in the case when the urltablealias contents change and pfSense reloads the alias but not its nested variant.
Also if there are too many entries it adds quite an overhead to the filter reload, possibly should add the other entries to the urltable alias file and make that persist?

#5 Updated by Chris Buechler almost 8 years ago

  • Status changed from Feedback to New
  • Target version changed from 2.1 to 2.0

This needs to be backed out and moved to target 2.1 for fixing, putting URL table aliases within network aliases results in a blank alias in the rules.

#6 Updated by Ermal Luçi almost 8 years ago

  • Target version changed from 2.0 to 2.1

Reverted the changes.

#7 Updated by Chris Buechler about 7 years ago

  • Target version deleted (2.1)
  • Affected Version deleted (2.0)

Also available in: Atom PDF