Bug #16954: Filter rules created as part of NAT rules can have an invalid protocol value - pfSense - pfSense bugtracker

Actions

Copy link

Bug #16954

open

Filter rules created as part of NAT rules can have an invalid protocol value

Added by Marcos M about 14 hours ago. Updated about 13 hours ago.

Status:

Feedback

Priority:

Normal

Assignee:

Marcos M

Category:

Rules / NAT

Target version:

2.9.0

Start date:

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

26.07

Release Notes:

Default

Affected Version:

Affected Architecture:

Description

NAT Port Forward rules with a protocol of "Any" which create an associated or unassociated filter rule will include <protocol>any</protocol> in the filter rule. This results in the GUI showing ANY in the protocol column instead of *.

Actions

Copy link

Updated by Marcos M about 13 hours ago

Status changed from New to Feedback
% Done changed from 0 to 100

Fixed with 22fa133178f4017fe750b0f9e78b8674f20c40fb and 95519a12a5b8bd46755e72df1d5c44dce6f098c0. Show Hide

diff --git a/src/usr/local/pfSense/include/www/firewall_nat.inc b/src/usr/local/pfSense/include/www/firewall_nat.inc
index 1ada6abfde..8a5e7d5f85 100644
--- a/src/usr/local/pfSense/include/www/firewall_nat.inc
+++ b/src/usr/local/pfSense/include/www/firewall_nat.inc
@@ -661,7 +661,9 @@ function saveNATrule($post, $id, $json = false) {
             // Update interface, protocol and destination
             $filterent['interface'] = $post['interface'];
             $filterent['ipprotocol'] = $post['ipprotocol'];
-            $filterent['protocol'] = $post['proto'];
+            if (!empty($post['proto']) && (strtolower($post['proto']) != 'any')) {
+                $filterent['protocol'] = $post['proto'];
+            }
             if (get_specialnet($post['localtype'], $rdr_lcltype_flags)) {
                 $filterent['destination']['network'] = $post['localtype'];
                 if (isset($filterent['destination']['address'])) {

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

pfSense

Custom queries

Bug #16954

Filter rules created as part of NAT rules can have an invalid protocol value

Updated by Marcos M about 13 hours ago