Actions
Todo #16961
open"Wake All" functionality on ``services_wol.php`` should only use POST
Start date:
Due date:
% Done:
100%
Estimated time:
Plus Target Version:
26.07
Release Notes:
Default
Description
The services_wol.php page allows a wakeall request to be submitted via GET and via POST, but it should only use POST for consistency and so that it has proper CSRF protection.
There are two sets of buttons on the page which allow the user to take this action, but they unnecessarily use different methods to submit the request. The first button uses GET, the second uses POST but does so with a dedicated bit of JavaScript. Neither method is the current proper approach.
If the link is changed as follows it will use POST and have a confirmation dialog:
<a href="services_wol.php?wakeall=true" role="button" class="btn btn-primary do-confirm" usepost>
The same method can be used for both buttons, the extra JavaScript block can then be removed.
Files
Updated by Jim Pingle 2 days ago
- File 16961.patch 16961.patch added
- Status changed from Confirmed to Feedback
- % Done changed from 0 to 100
Fixed in commit db4b79bfbcef4687039d4a65df64bd6118984d00
Patch is attached.
Actions