Project

General

Profile

Actions

Bug #1892

closed

Cannot static add static IPv6 route.

Added by Alexis Olivier over 13 years ago. Updated over 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Routing
Target version:
Start date:
09/21/2011
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1-IPv6
Affected Architecture:

Description

Commit bb5a2d0e727dee7d200d0f84dc76ef0c790e0c00 adds a bug in static route adding.

The dropdown box don't list subnets over 31.

The added code should be changed from :

 if(is_ipaddrv6($pconfig['network'])) {
        $size = 128;
      } else {
        $size = 32;
      }

to :
 if(is_ipaddrv4($pconfig['network'])) {
        $size = 32;
      } else {
        $size = 128;
      }

Actions #1

Updated by Seth Mos over 13 years ago

  • Status changed from New to Feedback

Hi,

I've committed your fix, please verify.

Actions #2

Updated by Alexis Olivier over 13 years ago

Hello,

You've made a typo line 182 :

if(is_ipaddrv64($pconfig['network'])) {

should be :

if(is_ipaddrv4($pconfig['network'])) {

For now, it breaks route adding. Otherwise it's working fine ! ;)

Actions #3

Updated by Seth Mos about 13 years ago

Your "fix" is not correct approach, needs more work. We need to be able to set a larger mask in case of a new ipv6 entry, otherwise a /31 would basically span a continent.

Actions #4

Updated by Chris Buechler almost 13 years ago

  • Target version changed from 8 to 2.1
Actions #5

Updated by Chris Buechler over 12 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF