Project

General

Profile

Actions
Copy link

Bug #1946

closed
CB

/usr/local/www/services_captiveportal.php

Bug #1946: /usr/local/www/services_captiveportal.php

Added by Cyrill B almost 15 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
2.1
Start date:
10/10/2011
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:
All

Description

/usr/local/www/services_captiveportal.php

lines 272 to 293
replace $config['captiveportal'] with $newcp

line 637
rename Primary to Tertiary

line 656
rename Secondary to Quaternary

line 369
Insert:

document.iform.radiusport3.disabled = radius_endis;
document.iform.radiusport4.disabled = radius_endis;

CB Updated by Cyrill B almost 15 years ago Actions
Copy link
 #1

line 642
replace second with third

line 661
replace second with fourth

Updated by Anonymous almost 15 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:d568e38d0275efebbe0c1969e26b31bdf125570e.

Updated by Anonymous almost 15 years ago Actions
Copy link
 #3

Applied in changeset commit:164a152577ccce56f896ea5ef020fcfbf60fe896.

CB Updated by Cyrill B almost 15 years ago Actions
Copy link
 #4

Small error in commit (Revision 164a1525)

lines 272 to 293

replace $config['captiveportal'] with $newcp

e.g. $newcp['captiveportal']['radiusip'] should have been $newcp['radiusip']

SU Updated by Scott Ullrich almost 15 years ago Actions
Copy link
 #5

Please open a new ticket for subsequent issues and please be sure the line #'s correspond with the prior changes.

Better yet - please fork our repo on github, fix the items and open a pull request.

CB Updated by Chris Buechler almost 15 years ago Actions
Copy link
 #6

  • Status changed from Feedback to New
  • Target version set to 2.1

The description is wrong and the fix is wrong. Opening this because it appears committing a fix broke at least something. These aren't 4 RADIUS servers, the description probably needs clarified but it's NOT Tertiary and Quaternary. I couldn't revert the commits easily, someone will have to take a closer look.

CB Updated by Chris Buechler over 14 years ago Actions
Copy link
 #7

  • Affected Version changed from 2.1-IPv6 to 2.1

CB Updated by Chris Buechler over 14 years ago Actions
Copy link
 #8

  • Status changed from New to Closed

#2322 open to fix what this broke and clear up the reason for the confusion.

Actions
Copy link

Also available in: Atom