Project

General

Profile

Bug #1946

/usr/local/www/services_captiveportal.php

Added by Cyrill B over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
Start date:
10/10/2011
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.1
Affected Architecture:
All

Description

/usr/local/www/services_captiveportal.php

lines 272 to 293
replace $config['captiveportal'] with $newcp

line 637
rename Primary to Tertiary

line 656
rename Secondary to Quaternary

line 369
Insert:

document.iform.radiusport3.disabled = radius_endis;
document.iform.radiusport4.disabled = radius_endis;

Associated revisions

Revision 164a1525 (diff)
Added by Scott Ullrich over 7 years ago

Fix multi instance cp items. Fixes #1946

Revision d568e38d (diff)
Added by Scott Ullrich over 7 years ago

Fix multi instance cp items. Fixes #1946

History

#1 Updated by Cyrill B over 7 years ago

line 642
replace second with third

line 661
replace second with fourth

#2 Updated by Anonymous over 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Anonymous over 7 years ago

#4 Updated by Cyrill B over 7 years ago

Small error in commit (Revision 164a1525)

lines 272 to 293

replace $config['captiveportal'] with $newcp

e.g. $newcp['captiveportal']['radiusip'] should have been $newcp['radiusip']

#5 Updated by Scott Ullrich over 7 years ago

Please open a new ticket for subsequent issues and please be sure the line #'s correspond with the prior changes.

Better yet - please fork our repo on github, fix the items and open a pull request.

#6 Updated by Chris Buechler over 7 years ago

  • Status changed from Feedback to New
  • Target version set to 2.1

The description is wrong and the fix is wrong. Opening this because it appears committing a fix broke at least something. These aren't 4 RADIUS servers, the description probably needs clarified but it's NOT Tertiary and Quaternary. I couldn't revert the commits easily, someone will have to take a closer look.

#7 Updated by Chris Buechler about 7 years ago

  • Affected Version changed from 2.1-IPv6 to 2.1

#8 Updated by Chris Buechler about 7 years ago

  • Status changed from New to Closed

#2322 open to fix what this broke and clear up the reason for the confusion.

Also available in: Atom PDF