Project

General

Profile

Actions

Bug #1978

closed

Multi-WAN+Multi-LAN shaper wizard VoIP bandwidth check is wrong

Added by Jim Pingle over 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Traffic Shaper (ALTQ)
Target version:
-
Start date:
10/25/2011
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.0
Affected Architecture:

Description

In traffic_shaper_wizard_multi_all.xml wizard when you get to the VoIP bandwidth screen there is a box for each WAN, and each LAN, to define VoIP bandwidths.

For example, let's say you have 2 WANs and 7 LANs.

The values are checked in a loop that doesn't appear to be matching things up right. It's looping over the number of local interfaces (in this case 7), and taking the value of conn{$i}downloadspeed (wan) and local{$i}downloadspeed (lan), when it gets to $i=2, this breaks as only WAN 0/1 exist. It gives an error about exceeding 80% but it's comparing it against a zero/null value so it's really an invalid value, not exceeding a limit.

Looks like it may be similar to the correction made in b0d088eb6fe3cf91ddd4aade1540a5749f551aa7 to one of the other wizards.

Actions #1

Updated by Chris Buechler over 13 years ago

  • Target version deleted (2.0.1)
  • Affected Version set to 2.0
Actions #2

Updated by Ermal Luçi over 13 years ago

  • Status changed from New to Feedback

Patched in mainline and 2.0.1

Actions #3

Updated by Jim Pingle about 13 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF