Project

General

Profile

Actions

Bug #2301

closed

Adding symlinks for conf files when PBI packages have names that are substrings of each other

Added by Phillip Davis over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Package System
Target version:
Start date:
03/20/2012
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

When installing Squid on 2.1-DEV the libwww, squid_radius_auth and squid packages are put on the system with PBI.
In pkg_utils.inc code tries to replace the conf files written by PBI with symlinks to the conf files that are written by pfSense. Code that tries to match {$pkg} fails when $pkg = "squid" because this matches both "squid" and "squid_radius_auth". The code needs to match more of the full PBI name, which always has a "-" after the base package name. So matching "squid-" will fix this issue. This is a general issue for packages that have names that are substrings of each other.
See the forum post [[http://forum.pfsense.org/index.php/topic,45487.15.html]] for the discussion.

Actions #1

Updated by Phillip Davis over 9 years ago

I also discovered that some packages have a mixed-case name, but that the PBI name is all lowercase. For example "squidGuard" has a PBI "squidguard-1.4_4-i386". So we also need to handle that when we have just the GUI-style package name (like "squidGuard") and want to find the full PBI package name using pbi_info.
delete_package cuts down the package name for display purposes, but remove_freebsd_package needs to be passed the complete PBI package name. This is why package deletes are not cleaning up the PBI files.
I will provide another pull request to fix these additional issues.

Actions #2

Updated by Phillip Davis over 9 years ago

This was resolved by pull requests 65, 66 and 67 in March 2012.

Actions #3

Updated by Chris Buechler over 9 years ago

  • Status changed from New to Resolved
Actions

Also available in: Atom PDF