Project

General

Profile

Actions

Feature #2436

closed

Enhance the restore section of the Backup/Restore section

Added by Seth Mos over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Backup / Restore
Target version:
Start date:
05/17/2012
Due date:
% Done:

90%

Estimated time:
Plus Target Version:
Release Notes:

Description

If restoring a partial config, we currently assume that only that section is uploaded. This is somewhat counterintuitive.

We want to make it possible to upload a entire config.xml and only act on the selected section, e.g. Firewall rules.

The standard config.xml has a root tag of pfSense, we should be able to go one level deeper to get to the data we need. This makes it easier to restore a single section.

Actions #1

Updated by Darren Embry over 9 years ago

  • Status changed from New to Feedback
  • Assignee changed from Darren Embry to Seth Mos
  • % Done changed from 0 to 90

Fixed in 428c289f and 8dcca9b5.

Reassigning to you so you can do further testing.
Please close if everything works for you.
Or reassign to me as needed with comments.

Actions #2

Updated by Seth Mos over 9 years ago

  • Status changed from Feedback to Assigned

When trying to restore just the RRD section on a current 31-5-2012 snapshots I get the following error.

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 90281672 bytes) in /usr/local/www/diag_backup.php on line 368

Perhaps you can tweak the code to use less memory

Actions #3

Updated by Seth Mos over 9 years ago

I can confirm that restoring an entire RRD file from a i386 onto a amd64 works as expected. Great work!

I must have been doing something wrong in the other ticket. Restoring a RRD section works fine, restored a amd64 RRD data onto a i386 box.

Works. Migration path works.

Actions #4

Updated by Seth Mos over 9 years ago

  • Status changed from Assigned to Resolved
Actions #5

Updated by Darren Embry over 9 years ago

Should I still look into the memory issue? My understanding is some of that XML parsing code we've been using has bitten us in the ass in the past.

Actions #6

Updated by Darren Embry over 9 years ago

If you want to make a new ticket for the memory issue I guess you can do that. :-)

Actions

Also available in: Atom PDF