Project

General

Profile

Actions

Bug #3340

closed

Captive Portal deletes concurrent sessions even if noconcurrentlogins is not set

Added by Chris Linstruth almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
Start date:
11/23/2013
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

Function captiveportal_prune_old_automac() deletes duplicate sessions even if noconcurrent logins is not set.

This comes into play when using vouchers with pass though mac automatic with username and disable concurrent logins unchecked.

Line 785 in etc/inc/captiveportal.inc:

if (isset($tmpvoucherdb[$emac['username']])) {

Should be:

if (isset($config['captiveportal'][$cpzone]['noconcurrentlogins']) && isset($tmpvoucherdb[$emac['username']])) {

Tested locally. Seems to work. All the automacs are cleared when voucher used expires.

Actions #1

Updated by Chris Linstruth almost 8 years ago

Or would it be better to:

if (isset($config['captiveportal'][$cpzone]['noconcurrentlogins'])) {
if (isset($tmpvoucherdb[$emac['username']])) {
...
}
$tmpvoucherdb[$emac['username']] = $eid;
}

Actions #3

Updated by Ermal Luçi over 7 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100
Actions #4

Updated by Ermal Luçi over 7 years ago

Actions #5

Updated by Renato Botelho over 7 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF