Project

General

Profile

Bug #3449

IE 8 does not respect disabled CIDR field when editing host alias, leading to filter ruleset syntax errors

Added by Jim Pingle over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
Start date:
02/13/2014
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.1
Affected Architecture:

Description

IE8 on XP (pause for laughter) does not respect the JavaScript that disables the CIDR field when editing a host alias. As a consequence, if you edit a host alias to add an IP the CIDR field is active and set to 128, and the JavaScript also does not automatically reset that to 32 even on a Network type alias. The /128 gets saved in the alias and then leads to filter reload errors because it's not a valid mask for an IPv4 address.

Even if we do not fix the front-end JS we should be ignoring the CIDR field entirely for a host type alias. The page could use some sanity checking to make sure the user can't save the alias with a bad mask. Even if the browser is braindead we shouldn't allow the invalid input.

How to repeat using IE 8:
Create a host alias, add one IP, save.
Edit the host alias, click + to add a new row

Current versions of IE and other browsers properly handle/respect the JavaScript and have no issues, but in the interest of preventing foot-shooting, the validation and/or backend issue should be addresses.

Associated revisions

Revision c00e6bd4 (diff)
Added by Renato Botelho over 7 years ago

Help ticket #3449:

Improve data validation to avoid save a host/subnet or a IPv4 with
invalid mask. The reported error is on javascript and only happen on
IE8,but this fix will prevent the same issue happening in the future on
a different browser.

Revision 18b4e253 (diff)
Added by Renato Botelho over 7 years ago

Help ticket #3449:

Improve data validation to avoid save a host/subnet or a IPv4 with
invalid mask. The reported error is on javascript and only happen on
IE8,but this fix will prevent the same issue happening in the future on
a different browser.

History

#1 Updated by Renato Botelho over 7 years ago

  • Status changed from New to Feedback

Move it to feedback since it should be enough for 2.1.1

#2 Updated by Jim Pingle over 7 years ago

  • Status changed from Feedback to Resolved

The input validation does not allow the problem case any longer. Looks good enough to me.

Also available in: Atom PDF