Project

General

Profile

Actions

Bug #3463

closed

MultiWAN test in system.php does not work

Added by Phillip Davis almost 12 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Very Low
Assignee:
-
Category:
DNS Forwarder
Target version:
-
Start date:
02/18/2014
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:

Description

/etc/inc.system.php defines a boolean $multiwan and uses that to decide whether to display the dropdown selection box to choose a gateway for each of the DNS Server IPs. But $multiwan == true if there are 1 or more gateways on the system. So all the gateway selection dropdown is displayed even on systems with only 1 gateway (WAN).
I suspect that people are quite used to this by now, and actually it is not a problem on 1 WAN systems, allowing the user to choose WAN_GW rather than the default route - it does not make any difference!
I guess that on a system without any gateways (just being used as a router in a local private network, the dropdown will not be displayed, because there are 0 gateways. That is correct.
If I fix this, then there might be people with 1 WAN systems who have selected WAN_GW. They won't be able to see that selection any more. If they change their system around in future then it could cause a problem because they will not be able to see that setting from the GUI.
Is this something to fix, or not?

Actions #1

Updated by Chris Buechler over 11 years ago

  • Status changed from New to Closed

True it isn't really useful in a single-WAN scenario, but I don't see any reason to prohibit that. There could be circumstances where you have only a single gateway defined, but are accepting routes elsewhere (maybe OSPF, BGP) that could be necessary. Given it possibly could be useful, I'm sure someone somewhere is reliant on the current behavior functioning, and I don't see any way it could hurt anything, it's best to leave it there.

Actions

Also available in: Atom PDF