Project

General

Profile

Bug #3904

Firewall Log widget generates a load of HTML code when Reverse DNS resolution is clicked

Added by Phillip Davis over 6 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Web Interface
Target version:
Start date:
09/30/2014
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.1.x
Affected Architecture:

Description

As per this forum report by chpalmer:
https://forum.pfsense.org/index.php?topic=82254.0

The version from 2.1 branch on Jun 17 works:
[url]https://github.com/pfsense/pfsense/commit/ee4ba9fba1f9d49396f3a4882a3239a83c5036d6[/url]

Later versions have had support for $GET changed and then removed. So it no longer works for diag_dns.php to be directly called like it is in the Firewall Log Widget.

My guess is that this functionality has to also be removed from the Firewall Log dashboard widget - log.widget.php - since it seems that the ability to easily call diag_dns.php to do an automatic reverse lookup has been removed.

But maybe $POST can be used here and the functionality preserved?

I'm sure someone who knows what functions were intended to be dropped from the diag_dns.php code can work out the corresponding thing to do with log.widget.php

This issue is in both 2.1.n branch and 2.2-BETA

History

#1 Updated by Chris Buechler over 6 years ago

  • Status changed from New to Resolved
  • Target version set to 2.2

Jim worked around this one. Phil, if you see anything that was missed, feedback appreciated but I think this is functionally OK in 2.2.

#2 Updated by Phillip Davis over 6 years ago

Also, this is the same as #3829, which is resolved, so good.
Now clicking the IP address takes the user to the full DNS Lookup page. If the user does not want to lose the Dashboard display, they can always right-click the link and "Open in New Tab". Seems fine.

Also available in: Atom PDF