pfSense » pfSense Packages

Simple patch to rename the temporary variable that's conflicting with the global $g.

--- mail_reports.inc.orig       2015-01-24 13:53:21.000000000 -0800
+++ mail_reports.inc    2015-01-24 13:57:42.000000000 -0800
@@ -531,7 +531,7 @@
                $graphcmd .= "--height 200 --width 620 ";

                $iflist = get_configured_interface_list();
-               $g = 0;
+               $h = 0;
                $operand = "";
                $comma = "";
                $graphtputbip = "";
@@ -577,7 +577,7 @@
                        $graphcmd .= "CDEF:\"{$ifname}-bytes_out_t_block={$ifname}-out_bytes,0,$speedlimit,LIMIT,UN,0,{$ifname}-out_bytes_block,IF,$seconds,*\" ";
                        $graphcmd .= "CDEF:\"{$ifname}-bytes_t_pass={$ifname}-bytes_in_t_pass,{$ifname}-bytes_out_t_pass,+\" ";
                        $graphcmd .= "CDEF:\"{$ifname}-bytes_t_block={$ifname}-bytes_in_t_block,{$ifname}-bytes_out_t_block,+\" ";
-                       if ($g > 0) {
+                       if ($h > 0) {
                                $operand .= ",+";
                                $comma = ",";
                        }
@@ -593,7 +593,7 @@
                        $graphtputbyob .= "{$comma}{$ifname}-bytes_out_t_block";
                        $graphtputbytp .= "{$comma}{$ifname}-bytes_t_pass";
                        $graphtputbytb .= "{$comma}{$ifname}-bytes_t_block";
-                       $g++;
+                       $h++;
                }
                $graphcmd .= "CDEF:\"tput-in_bits_pass={$graphtputbip}{$operand}\" ";
                $graphcmd .= "CDEF:\"tput-out_bits_pass={$graphtputbop}{$operand}\" ";

Thanks for fixing the project - didn't realize which project I was in when I opened the issue.

I went ahead and opened a pullreq on Github too, in case that makes this easier to address. (Then again, it's a very simple patch.)
https://github.com/pfsense/pfsense-packages/pull/793