Project

General

Profile

Bug #431

[PATCH] Modify get_pkg_depends to return whole paths

Added by Lorenz Schori about 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
03/17/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

The function sync_package from /etc/inc/pkg-utils.inc ensures that all required files from a particular package are present on system startup. The list of files a package depends on is compiled by get_pkg_depends which parses the xml configuration. Unfortunately the current implementation always looks for the dependency files in /usr/local/pkg and does not consider the optional prefix. Therefore a package containing dependency files with a non-standard prefix will always get reinstalled on each bootup. The attached logfiles illustrate this behaviour.

The attached patch fixes the functions sync_package and get_pkg_depends.

0001-Modify-get_pkg_depends-to-return-whole-paths.patch (2.5 KB) 0001-Modify-get_pkg_depends-to-return-whole-paths.patch Lorenz Schori, 03/17/2010 09:20 AM
console-log-before.txt (1.98 KB) console-log-before.txt Lorenz Schori, 03/17/2010 09:20 AM
system-log-before.txt (2.36 KB) system-log-before.txt Lorenz Schori, 03/17/2010 09:20 AM
console-log-after.txt (224 Bytes) console-log-after.txt Lorenz Schori, 03/17/2010 09:20 AM
system-log-after.txt (693 Bytes) system-log-after.txt Lorenz Schori, 03/17/2010 09:20 AM

Associated revisions

Revision 40a721c0 (diff)
Added by Scott Ullrich about 9 years ago

get_pkg_depends must return the whole paths of dependency files in order
to enable sync_package to check for files which are not installed in the
standard pkg location (i.e. outside of /usr/local/pkg).

Ticket #431
Submitted-by: Lorenz Schori

History

#1 Updated by Scott Ullrich about 9 years ago

  • Status changed from New to Feedback

Commited, thanks! Please let us know if it is resolved on the next snapshot.

#2 Updated by Chris Buechler about 9 years ago

  • Target version set to 2.0

#3 Updated by Lorenz Schori about 9 years ago

Tested with pfSense-2.0-BETA1-20100317-2238.iso and tinydns pkg. It works, thanks.

#4 Updated by Chris Buechler about 9 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF