Project

General

Profile

Bug #4384

missing input validation in captive portal

Added by Chris Buechler over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
Start date:
02/06/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

services_captiveportal.php is missing input validation that allows creating invalid configurations, including ones that can trigger crash reports like:

PHP Fatal error:  Class 'Auth_RADIUS_' not found in /usr/local/captiveportal/radius_authentication.inc on line 80

In that case, RADIUS auth is chosen, but "RADIUS protocol" beneath it left empty and unselected.

Where RADIUS auth is enabled, it must require entry of a RADIUS server IP or hostname for the primary authentication source, and a choice of RADIUS protocol.

Associated revisions

Revision 10b92c57 (diff)
Added by Renato Botelho over 4 years ago

When RADIUS auth is selected, radius protocol and server ip/host are mandatory. Fixes #4384

Revision aa314146 (diff)
Added by Renato Botelho over 4 years ago

When RADIUS auth is selected, radius protocol and server ip/host are mandatory. Fixes #4384

History

#1 Updated by Renato Botelho over 4 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#3 Updated by Chris Buechler over 4 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF