Project

General

Profile

Bug #4485

last commit broke globals.inc

Added by Gavin J about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
Start date:
03/04/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.2.1
Affected Architecture:
amd64

Description

Hi Jim,
The last commit you made to globals.inc (http://freshbsd.org/commit/pfsense/1dbe220c9b201550bf9f10c45ab14b8d30c4bacd) for the CARP changes is missing a comma at the end of the preceding line.

i.e.

    "net.enc.in.ipsec_filter_mask" => "0x0002" 
    "net.inet.carp.senderr_demotion_factor" => 0, /* Do not demote CARP for interface send errors */
    "net.pfsync.carp_demotion_factor" => 0 /* Do not demote CARP for pfsync errors */

should be
    "net.enc.in.ipsec_filter_mask" => "0x0002",
    "net.inet.carp.senderr_demotion_factor" => 0, /* Do not demote CARP for interface send errors */
    "net.pfsync.carp_demotion_factor" => 0 /* Do not demote CARP for pfsync errors */

Thanks

Associated revisions

Revision a832806c (diff)
Added by Jim Pingle about 5 years ago

Add missing comma. Fixes #4485

Revision 24ad8e26 (diff)
Added by Jim Pingle about 5 years ago

Add missing comma. Fixes #4485

History

#1 Updated by Jim Pingle about 5 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Gavin J about 5 years ago

Confirmed resolved after gitsync. Thanks.

#4 Updated by Chris Buechler about 5 years ago

  • Status changed from Feedback to Resolved
  • Target version set to 2.2.1

fixed

Also available in: Atom PDF