Project

General

Profile

Bug #4738

Setup Wizard can result in invalid LAN DHCP pool calculation

Added by Phillip Davis about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DHCP Server
Target version:
Start date:
06/02/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

The DHCP pool automatic calculation on LAN done by the Setup Wizard always starts the pool at ".10" in relation to the given LAN IP and finishes it 10 addresses before the end of the subnet. This can result in:
1) The specified LAN IP could be in the DHCP pool
2) If someone uses an unusually small LAN subnet mask, then
a) ".10" might not be in the subnet
b) the subnet might not be big enough to make a DHCP range that goes from ".10" to 10 addresses from the end of the subnet. e.g. a LAN of /28 only has 16 addresses total.
3) A subnet mask of 32 can be selected - that just generally makes the world go wrong :)

Problem (1) is the most likely to happen - e.g. someone types in LAN IP 192.168.1.123 and it sits in the middle of the DHCP Pool.

I have some enhanced calculation and validation code for the setup wizard that I will submit...

History

#2 Updated by Phillip Davis about 4 years ago

Committed by https://github.com/pfsense/pfsense/commit/3a19fd4a84d358ff8e6c9eedcad5b11f7f570fa8
and also to 2.2 branch for 2.2.3 - so target version could be set to 2.2.3

#3 Updated by Phillip Davis about 4 years ago

The commit to 2.2 branch was:
https://github.com/pfsense/pfsense/commit/dc6695c3f41f65dd3232e311e589bad217bb4c10
This code is in 2.2.3-RELEASE so target version can be 2.2.3 and it can be tested and marked resolved.

#4 Updated by Chris Buechler about 4 years ago

  • Status changed from New to Resolved
  • Target version set to 2.2.3

Also available in: Atom PDF