Project

General

Profile

Actions

Bug #4865

closed

Save IPsec Advanced Settings before IPsec is enabled gives error

Added by Phillip Davis over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
IPsec
Target version:
Start date:
07/22/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

On a system that does not have IPsec enabled, go to VPN->IPsec, Advanced Settings tab and press Save (leave all the default settings).
It gives:
Fatal error: Cannot unset string offsets in /usr/local/www/vpn_ipsec_settings.php on line 168

The various unset() all through there for Boolean check-boxes need to be protected with "if isset()", because in this case $config["ipsec"] is just an empty string.
I noticed while having a quick look at https://redmine.pfsense.org/issues/4864

It will be easy to fix. I will look in a few hours tonight.

Actions #1

Updated by Phillip Davis over 8 years ago

Also if you select some debug level settings when saving the very first time, then those are not actually saved.

This and the unset() errors are fixed by https://github.com/pfsense/pfsense/pull/1777

Actions #3

Updated by Chris Buechler over 8 years ago

  • Status changed from New to Resolved
  • Target version set to 2.2.4
Actions

Also available in: Atom PDF