Project

General

Profile

Actions

Bug #4865

closed
PD PD

Save IPsec Advanced Settings before IPsec is enabled gives error

Bug #4865: Save IPsec Advanced Settings before IPsec is enabled gives error

Added by Phillip Davis about 11 years ago. Updated about 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
IPsec
Target version:
Start date:
07/22/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

On a system that does not have IPsec enabled, go to VPN->IPsec, Advanced Settings tab and press Save (leave all the default settings).
It gives:
Fatal error: Cannot unset string offsets in /usr/local/www/vpn_ipsec_settings.php on line 168

The various unset() all through there for Boolean check-boxes need to be protected with "if isset()", because in this case $config["ipsec"] is just an empty string.
I noticed while having a quick look at https://redmine.pfsense.org/issues/4864

It will be easy to fix. I will look in a few hours tonight.

PD Updated by Phillip Davis about 11 years ago Actions #1

Also if you select some debug level settings when saving the very first time, then those are not actually saved.

This and the unset() errors are fixed by https://github.com/pfsense/pfsense/pull/1777

CB Updated by Chris Buechler about 11 years ago Actions #3

  • Status changed from New to Resolved
  • Target version set to 2.2.4
Actions

Also available in: Atom