Bug #4866
closedL2TP server are restarted after adding/modifying L2TP users (mpd.secret)
100%
Description
Full daemon restart is useless since mpd reads mpd.secret on the fly (as I can uderstand from mpd4's code). One problem with this restart is that Quagga OSPF don't like to see mpd deleting ang creating L2TP interfaces. After mpd restart in Quagga status I can see both l2tpXXX anf ngXX interfaces. Quagga restart solves problem.
Quagga OSPF status after mpd restart (both l2tpXXX ang ngXXX interfaces):
l2tp0 is down ifindex 0, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST> OSPF not enabled on this interface ... l2tp9 is down ifindex 0, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST> OSPF not enabled on this interface ... ng0 is up ifindex 9, MTU 1500 bytes, BW 0 Kbit <UP,POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST> Internet Address 192.168.221.1/32, Peer 192.168.221.128, Area 0.0.0.0 MTU mismatch detection:enabled Router ID 10.10.15.250, Network Type BROADCAST, Cost: 10 Transmit Delay is 1 sec, State Waiting, Priority 1 No designated router on this network No backup designated router on this network Multicast group memberships: OSPFAllRouters Timer intervals configured, Hello 10s, Dead 40s, Wait 40s, Retransmit 5 Hello due in 6.903s Neighbor Count is 0, Adjacent neighbor count is 0 ... ng9 is down ifindex 18, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST> OSPF not enabled on this interface
Updated by Viktor Gurov over 4 years ago
This PR moves creation of the mpd.secret file to a separate function that does not restart mpd daemon:
https://github.com/pfsense/pfsense/pull/4216
Updated by Jim Pingle over 4 years ago
If this works, we should also change the PPPoE server to behave the same way. That should be a separate Redmine issue + PR, though.
Updated by Jim Pingle over 4 years ago
- Status changed from New to Pull Request Review
- Target version set to 2.5.0
Updated by Renato Botelho over 4 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Viktor Gurov over 4 years ago
- Status changed from Feedback to Resolved
works as expected on 2.5.0.a.20200311.1716
Updated by Jim Pingle over 4 years ago
- Status changed from Resolved to Feedback
- Target version changed from 2.5.0 to 2.4.5-p1
Updated by Jim Pingle over 4 years ago
- Status changed from Feedback to Resolved
mpd process is no longer restarted after making changes to users.
Also confirmed that changing a password while it was running was respected.