Project

General

Profile

Bug #4866

L2TP server are restarted after adding/modifying L2TP users (mpd.secret)

Added by Taras Savchuk over 4 years ago. Updated 23 days ago.

Status:
Resolved
Priority:
Normal
Category:
L2TP
Target version:
Start date:
07/22/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

Full daemon restart is useless since mpd reads mpd.secret on the fly (as I can uderstand from mpd4's code). One problem with this restart is that Quagga OSPF don't like to see mpd deleting ang creating L2TP interfaces. After mpd restart in Quagga status I can see both l2tpXXX anf ngXX interfaces. Quagga restart solves problem.

Quagga OSPF status after mpd restart (both l2tpXXX ang ngXXX interfaces):

l2tp0 is down
  ifindex 0, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST>
  OSPF not enabled on this interface

...

l2tp9 is down
  ifindex 0, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST>
  OSPF not enabled on this interface
...
ng0 is up
  ifindex 9, MTU 1500 bytes, BW 0 Kbit <UP,POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST>
  Internet Address 192.168.221.1/32, Peer 192.168.221.128, Area 0.0.0.0
  MTU mismatch detection:enabled
  Router ID 10.10.15.250, Network Type BROADCAST, Cost: 10
  Transmit Delay is 1 sec, State Waiting, Priority 1
  No designated router on this network
  No backup designated router on this network
  Multicast group memberships: OSPFAllRouters
  Timer intervals configured, Hello 10s, Dead 40s, Wait 40s, Retransmit 5
    Hello due in 6.903s
  Neighbor Count is 0, Adjacent neighbor count is 0

...

ng9 is down
  ifindex 18, MTU 1500 bytes, BW 0 Kbit <POINTOPOINT,RUNNING,NOARP,SIMPLEX,MULTICAST>
  OSPF not enabled on this interface

Associated revisions

Revision 81092348 (diff)
Added by Viktor Gurov about 1 month ago

Do not restart L2TP server after adding/modifying users. Issue #4866

History

#1 Updated by Viktor Gurov about 1 month ago

This PR moves creation of the mpd.secret file to a separate function that does not restart mpd daemon:
https://github.com/pfsense/pfsense/pull/4216

#2 Updated by Jim Pingle about 1 month ago

If this works, we should also change the PPPoE server to behave the same way. That should be a separate Redmine issue + PR, though.

#3 Updated by Jim Pingle about 1 month ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0

#4 Updated by Renato Botelho 27 days ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

#5 Updated by Viktor Gurov 23 days ago

  • Status changed from Feedback to Resolved

works as expected on 2.5.0.a.20200311.1716

Also available in: Atom PDF