Bug #4925
closedversion_compare_numeric does not work for 2.2.9 to 2.2.10
0%
Description
version_compare_numeric correctly compares 2.2.8 to 2.2.9 and thinks 2.2.9 is an upgrade - good.
But comparing 2.2.9 to 2.2.10 it thinks 2.2.10 is an earlier version than 2.2.9 - not good.
The same problem exists for any last number position in the dot-separated list - e.g. 3.9 to 3.10 will not be seen as an upgrade.
I would like to use this an related functions to compare package versions also. Package versions often transition from (0.9 to 0.10) (1.1.9 to 1.1.10) (1.1.19 to 1.1.20). So it would be nice to fix the function.
Updated by Phillip Davis over 9 years ago
Pull request https://github.com/pfsense/pfsense/pull/1810
Updated by Chris Buechler about 9 years ago
- Status changed from New to Confirmed
Updated by Phillip Davis about 9 years ago
The PR for master that was merged: https://github.com/pfsense/pfsense/pull/1826
and for RELENG_2_2: https://github.com/pfsense/pfsense/pull/1835
Updated by Chris Buechler about 9 years ago
- Status changed from Confirmed to Resolved
- Target version set to 2.2.5
- Affected Version set to All
Thanks Phil.