Project

General

Profile

Bug #493

Checkboxes saved outside of setup wizard do not show checked in wizard

Added by Erik Fonnesbeck over 9 years ago. Updated about 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
04/09/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

The setup wizard does not properly display checkbox settings where the configuration setting is just set, but not assigned a value, if the setting was saved outside of the wizard. For example, if the DNS allow override setting is enabled during the setup wizard, the configuration looks like this and will show as checked when you go back to the wizard:

<dnsallowoverride>on</dnsallowoverride>

However, if you save the settings in System: General, it will look like this and will not show as checked in the wizard:

<dnsallowoverride/>

Both are valid ways to enable the setting, but the wizard does not properly handle the latter case when displaying the settings.

Associated revisions

Revision ba374e4b (diff)
Added by Ermal Luçi about 9 years ago

Ticket #493. Ticket #302. Actually correct code flow to be correct and consistent to what it should do.

Revision 373a1e7b (diff)
Added by Ermal Luçi about 9 years ago

Ticket #493. Set a value for checkboxes since the parsers marks empty tags(<tag/>) as arrays.

History

#1 Updated by Ermal Luçi about 9 years ago

  • Status changed from New to Feedback

Patched.

#2 Updated by Erik Fonnesbeck about 9 years ago

This is still an issue with latest code.

#3 Updated by Chris Buechler about 9 years ago

  • Status changed from Feedback to New

#4 Updated by Ermal Luçi about 9 years ago

  • Status changed from New to Feedback

#5 Updated by Erik Fonnesbeck about 9 years ago

  • Status changed from Feedback to Resolved

It seems to be fixed now. I tried enabling/disabling it on either page and both now show the correct enabled or disabled state regardless of which of them enabled or disabled the setting.

Also available in: Atom PDF