Project

General

Profile

Actions
Copy link

Bug #5099

closed

firewall_rules_edit.php - Destination Port options are hidden on page load with TCP or UDP

Added by Jim Pingle over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Target version:
pfSense - 2.3
Start date:
09/03/2015
Due date:
% Done:

100%

Estimated time:
Spent time:
0.50 h

Description

When creating a new rule, or editing an existing TCP or UDP rule, the destination ports are hidden even though the rule defaults to TCP.

Changing the rule to some other value and then back to TCP or UDP shows the destination port controls as expected.

Actions
Copy link
 #1

Updated by Anonymous over 9 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Corrected destination port group class

Actions
Copy link
 #2

Updated by Anonymous over 9 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Jim Pingle over 9 years ago

  • Status changed from Feedback to Confirmed
  • Assignee changed from Jim Pingle to Anonymous

The destination ports are appearing now, but so are the source ports, which should remain hidden.

  • New rule, defaults to TCP - OK, source ports hidden, destination ports shown
  • New rule, change to UDP or TCP/UDP - Advanced button still shows but source ports appear (Bad), destination ports are shown (Good)
  • Edit existing rules TCP, UDP, or TCP/UDP - OK on initial page load, source ports hidden, destination ports shown. Switch rule type to any other of TCP, UDP, or TCP/UDP and the same bad behavior appears: Advanced button still shows but source ports appear (Bad), destination ports are shown (Good)
Source ports should only appear in two conditions:
  • User manually clicks advanced
  • Source port already contains a value.
Actions
Copy link
 #4

Updated by Anonymous over 9 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Anonymous to Chris Buechler
Actions
Copy link
 #5

Updated by Anonymous over 9 years ago

Actions
Copy link
 #6

Updated by Jim Pingle over 9 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Chris Buechler to Anonymous

No change in behavior from my previous test with the last commit in place.

Actions
Copy link
 #7

Updated by Anonymous over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Javascript logic changged for source port display "Advanced" button now has toggle acton and its state survives a protocol change.

Actions
Copy link
 #8

Updated by Anonymous over 9 years ago

Actions
Copy link
 #9

Updated by Jim Pingle over 9 years ago

  • Status changed from Feedback to Assigned
  • Assignee changed from Jim Pingle to Anonymous

The source port behavior is better, but the destination ports have gone missing.

So two problems now:
  • If Source ports already contain a value, they should be shown without having to click Advanced
  • Destination ports need to be restored, they are not displayed at all on new rules or rules with existing destination ports. They should always be shown for TCP, UDP, and TCP/UDP.
Actions
Copy link
 #10

Updated by Anonymous over 9 years ago

First item is covered in bug #5045 so I'd like to continue to keep it separate and not just for this page.

Glad the source ports are now good. I'll do something similar to the dest ports.

Actions
Copy link
 #11

Updated by Anonymous over 9 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Anonymous to Jim Pingle

Destination ports now behave as required.

If Source ports already contain a value, they should be shown without having to click Advanced will be dealt with via Bug #5045

Actions
Copy link
 #12

Updated by Anonymous over 9 years ago

Actions
Copy link
 #13

Updated by Jim Pingle over 9 years ago

  • Status changed from Feedback to Resolved

Looks good now, thanks!

Actions
Copy link

Also available in: Atom PDF