Bug #5205
closed
squid General Tab configuration can't be saved
100%
Description
- squid 2.7.9 pkg v.4.3.9
Only configured LAN IP address to access GUI.
Go to System > Packages to install squid package
Go to Services > Proxy Server > General
Try to edit a parameter (i.e. Proxy Port) click "Save" and get:
Fatal error: Cannot use string offset as an array in /usr/local/pkg/squid.inc on line 931
If I manually modify config.xml to add a configuration from a working pfSense with Squid I get those change applied on the General Tab but I can't change it, always are presented the same values. Other squid configuration tabs behave correctly, allowing to write changes.
Updated by Kill Bill over 8 years ago
Please, use pfSense versions and package versions that are actually maintained. pfSense 2.1.5 and Squid 2.7.9 are not among those.
Updated by Toni Garcia over 8 years ago
pfSense 2.2.4 with squid (either version 2 or version 3) is buggy.
I had to correct startup scripts in order to get squid autostart on reboot.
Updated by Chris Buechler over 8 years ago
- Category set to Squid
- Status changed from New to Needs Patch
unsupported version
Updated by Toni Garcia over 8 years ago
squid 2.7.9_4 is the last version available to install on pfSense 2.2.4, and squid 2.7.9_3 the last for pfSense 2.1.5.
Both are the only tagged as "Stable" in the packages list for each version.
The bug status being changed to "Needs Patch" means that it will be fixed?
Updated by Jim Pingle over 8 years ago
- Status changed from Needs Patch to Feedback
Will be fixed once package version 4.3.10 shows up in a few minutes. A variable was being treated like an array without being properly initialized first. It only did not show an error on 2.2.x because we patched out that error check in PHP, IIRC.
Updated by Jim Pingle over 8 years ago
- % Done changed from 0 to 100
Applied in changeset commit:bcb21f8020f5b886d11aba49bd7b935a6b3cff6f.
Updated by Toni Garcia over 8 years ago
After upgrade to version 4.3.10, when applying changes on the General Tab they are ignored, always presenting the same values.
Other squid configuration tabs behave correctly, allowing to write changes.
Updated by Toni Garcia over 8 years ago
This issue still exists on pfSense 2.1.5, the general parameters for Squid can't be edited from GUI.
Please confirm if this will be fixed.
Updated by Jim Pingle over 8 years ago
Applied in changeset commit:7d613d5c35a0effaadfe409cc80e07068fdcc39b.
Updated by Toni Garcia over 8 years ago
This version of squid.inc seems to solve the problem of saving general parameters.
When the fixed version will be available to install from pfsense gui?
Updated by Jim Pingle over 8 years ago
It was available in the package repo at the same time the commit showed up here on the ticket. It's there now.
Updated by Chris Buechler over 8 years ago
- Status changed from Feedback to Resolved
Updated by Kill Bill over 8 years ago
I would truly appreciate if someone traced the real cause of the install_cron_job() breakage, instead of reverting things to completely shitty code. Someone's reporting the same with Squid 3.4 on pfSense 2.2.4. This is something I totally cannot reproduce no matter what.
https://forum.pfsense.org/index.php?topic=100167.msg561072#msg561072
Updated by Jim Pingle over 8 years ago
It's most likely something in the way it (re)reads/parses or writes the config which causes the existing $config to be wiped before being saved. I was echoing out values at various points and before it hit that part, the squid settings were in $config and after they were gone. I seem to recall hitting that in the past but couldn't find the reference again. Even though the code is shit, it works, and it's wrong to leave it broken for many people while diagnosing the underlying problem. If it happens on 2.2.x then it can maybe be fixed there. I didn't bother looking deeper here since I figured it was a base system bug on 2.1.x which is dead, and the squid 2.7.x package will be dead sooner rather than later as well.