Project

General

Profile

Bug #5210

Package logging entries are not being removed from syslog.conf on package uninstall

Added by Kill Bill about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
09/27/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

This is what's being added for those packages - /etc/inc/system.inc

$syslogconf .= "!{$package['logging']['facilityname']}\n*.*\t\t\t\t\t\t {$log_directive}{$g['varlog_path']}/{$package['logging']['logfilename']}\n";

This is what's attempted to be removed on uninstall:

remove_text_from_file("/etc/syslog.conf", $pkg_info['logging']['facilityname'] . "\t\t\t\t" . $pkg_info['logging']['logfilename']);

These two very obviously do not match, cannot work.

Associated revisions

Revision 0c2f769c (diff)
Added by Doktor Notor about 4 years ago

Remove syslog.conf entries on package uninstall (Bug #5210) - RELENG_2_2

The remove_text_from_file() is not needed at all. However, system_syslogd_start() must be run after the package entries are gone from config.xml, otherwise system_syslogd_start() just re-adds the (now almost removed) package logging configuration from there.

Revision ce7edfff (diff)
Added by Doktor Notor about 4 years ago

Remove syslog.conf entries on package uninstall (Bug #5210)

The remove_text_from_file() is not needed at all. However, system_syslogd_start() must be run after the package entries are gone from config.xml, otherwise system_syslogd_start() just re-adds the (now almost removed) package logging configuration from there.

History

#1 Updated by Kill Bill about 4 years ago

https://github.com/pfsense/pfsense/pull/1939 (RELENG_2_2)
https://github.com/pfsense/pfsense/pull/1940 (master)

The problem here is that system_syslogd_start() is called at wrong time.

#2 Updated by Renato Botelho about 4 years ago

  • Status changed from New to Feedback
  • Target version set to 2.2.5
  • % Done changed from 0 to 100

Pull requests have been merged. Thanks!

#3 Updated by Chris Buechler about 4 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF