Project

General

Profile

Bug #5228

Empty space before (drop-down) field display value

Added by Steve Beaver almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Target version:
Start date:
10/01/2015
Due date:
% Done:

0%

Estimated time:

Description

For example, go to Interfaces->LAN and look at IPv4 or IPv6 Configuration Type. The text of the selected value (e.g. Static IPv4) has some space in front of it. That space was not there in 2.2.*

When the drop-down arrow is clicked to show the drop-down list, the text of the list lines up against the left side of the column, like I expected. It does not line up with the text of the currently-selected item.

History

#1 Updated by Steve Beaver almost 4 years ago

  • Tracker changed from Bug to Todo

#2 Updated by jeroen van breedam over 3 years ago

<select class=form-control> form-control has padding enabled
the class is not applied to it's <option>'s

so either we remove the padding from form-control (would advice against it, doesn't look that great).
or
we create a new entry in pfsense.css ".form-select-option" and add padding to it. then add it as a class in the <option> fields
or
?

i can create a PR for either solutions if you want, lemme know which solution you prefer

#3 Updated by Steve Beaver over 3 years ago

Thanks. If we really need to do this, I think your second scheme "create a new entry in pfsense.css ".form-select-option" is the best option.

A PR would be appreciated.

#4 Updated by jeroen van breedam over 3 years ago

found a way to fix it without having to manually add classes to the option fields

https://github.com/pfsense/pfsense/pull/2001

#5 Updated by jeroen van breedam over 3 years ago

to clarify myself: google found a way to fix.....

i'm just idiot with some spare time ;)

#6 Updated by Steve Beaver over 3 years ago

  • Tracker changed from Todo to Bug
  • Status changed from Confirmed to Feedback

A combination of the suggested methods seems to produce the best display. Select padding has been reduced from 12 to 6, and the option padding set to inherit the same value.

#7 Updated by Steve Beaver over 3 years ago

  • Status changed from Feedback to Resolved

#8 Updated by Chris Buechler over 3 years ago

  • Affected Version set to 2.3

Also available in: Atom PDF