Project

General

Profile

Bug #5234

Edit file Save does not work

Added by Phillip Davis almost 4 years ago. Updated almost 4 years ago.

Status:
Resolved
Priority:
Normal
Target version:
Start date:
10/01/2015
Due date:
% Done:

100%

Estimated time:

Description

2.3-ALPHA (amd64)
built on Thu Oct 01 19:28:03 CDT 2015

I am trying to edit /cf/conf/config.xml to work around some other things.
I can browse folders /cf into /cf/conf and load config.xml no problem.
I make changes and press Save. But there is no apparent action, no feedback.
If I Load again, the old contents are displayed.

I tried editing a file in /usr/local/www also, same problem that Save does not do anything.

This would be handy to have working for debugging and quick fixes.

Associated revisions

Revision e561ccdf (diff)
Added by Steve Beaver almost 4 years ago

Fixed #5234
Javascript Base64 class was MIA

History

#1 Updated by Chris Buechler almost 4 years ago

  • Status changed from New to Confirmed
  • Assignee set to Steve Beaver

#2 Updated by Steve Beaver almost 4 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Chris Buechler

Javascript Base64 class had been removed. It has now been included in edit.php and hte save button works as expected.

#3 Updated by Steve Beaver almost 4 years ago

  • % Done changed from 0 to 100

#4 Updated by Phillip Davis almost 4 years ago

2.3-ALPHA (amd64)
built on Sat Oct 03 00:06:10 CDT 2015
FreeBSD 10.2-STABLE

Save is working, thanks.

#5 Updated by Phillip Davis almost 4 years ago

The "File saved successfully" message has no "x" to remove it. Other success messages (e.g. after editing and alias and apply changes) have an "x" at the right-hand side.
It is convenient to be able to dismiss a success message. Then if you make another edit and press save it is clear that a new "success" message gets displayed.
For some reason edit.php has different more direct code that makes these messages, compared to firewall_aliases.php, which calls print_info_box(). I tried quickly putting print_info_box() into edit.php - but it seems there is more infrastructure needed in edit.php to make that work?

#6 Updated by Chris Buechler almost 4 years ago

  • Status changed from Feedback to Resolved

issue's fixed. the success message isn't that big of a deal, but if you find a way to add dismiss there Phil, feel free to submit a pull request

Also available in: Atom PDF