Project

General

Profile

Bug #5372

Two rules created if double click the Save button (by mistake)

Added by TCI User over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
-
Category:
Web Interface
Target version:
Start date:
11/04/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

My browser is Chrome v.46.0.2490.80
When creating a new rule and double click the Save button (by mistake) the GUI generate two identical rules.
It is not the end of the world but did not find it in the bug-tracker so decided to report it.

Note: There is no problem if you update an existing rule and double click the Save button.

History

#1 Updated by Phillip Davis over 3 years ago

I can replicate this by slowly clicking Save twice. If I purposely do a "double-click"speed double-click it does not happen. It seems that the browser is doing a POST all over again while it is still waiting for the first POST to complete.
Of course, if you do that when editing an existing anything then it effectively does the same edit/update twice. Which is generally harmless and is not noticed.
I tried the same with adding an Alias. The system adds the alias (first POST action) and then reports "An alias with this name already exists." (second repeated POST action of the same add). In this case there is a unique field that is enforced so the second POST attempt fails validation.

I got the same on Chrome (46.0.2490.80) and Firefox (38.3.0). I guess there needs to be some magic done to prevent various buttons from having any effect while still waiting for response to a previous button press.

The behavior is the same on pfSense 2.2.5-DEVELOPMENT and 2.3-ALPHA

#2 Updated by Kill Bill over 3 years ago

This got misfiled under packages bugs.

#3 Updated by TCI User over 3 years ago

Kill Bill wrote:

This got misfiled under packages bugs.

Sorry about that. This was my first report and I did not notice that there is a sub-category Packages. I was reading some other bug reports so I can properly present this one and probably the last one was from the Packages section.

Can I transfer my report or it has to be done by the admins?

Please advise.

#4 Updated by Steve Beaver over 3 years ago

I will move it later today (after you have had time to read this :) )

#5 Updated by Chris Buechler over 3 years ago

  • Project changed from pfSense Packages to pfSense
  • Affected Version changed from 2.2.4 to All

#6 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Resolved

"Save" button is disabled on clicking "Save" thereby preventing a double click.

#7 Updated by Chris Buechler over 3 years ago

  • Category set to Web Interface
  • Target version set to 2.3
  • Affected Architecture deleted (i386)

Also available in: Atom PDF