Project

General

Profile

Actions

Feature #5485

closed

service-utils.inc/service_control_stop() needs some checks before claiming success

Added by Kill Bill over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Operating System
Target version:
Start date:
11/19/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:

Description

This is a follow-up to #5468 - this just shouldn't claim "$service has been stopped" without any checking, it says the same even in cases where no attempt to do anything has been done because the code path did not find any usable way to attempt stopping that particular service. E.g., doing something like s_process_running($foo) before spitting out the message seems like an easy way to me for most cases.

https://github.com/pfsense/pfsense/blob/master/src/etc/inc/service-utils.inc#L730

Actions

Also available in: Atom PDF