Project

General

Profile

Actions

Bug #5529

closed

Captive Portal Status

Added by Phillip Davis almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Captive Portal
Target version:
Start date:
11/24/2015
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

1) Have no Captive Portal Zones defined. From the dashboard select Status->Captive Portal
It should have a normal heading etc with no status information to display. Instead there is "Captive Portal Status ()" and the shortcut items are not formatted nicely.

2) Select Services->Captive Portal. Now there is logic somewhere that takes the "Captive Portal" item off the Status menu. That happens if there are no Zones defined. I guess the intent there is that nobody can get to the Captive Portal Status page if there are no Zones defined.
But there are shortcut links on Services->Captive Portal that take you to the related status.
And if you are on the dashboard or other pages, then the Status->Captive Portal menu item appears.
Item (2) seems to be the behavior in 2.2.5 also.

Suggestion:
a) Make Status->Captive Portal have a good display in the case when there are no Zones.
b) Remove any logic that tries to add/remove "Captive Portal" from the Status menu - that is all too smart for its own good.

Other services are happy to display "null status" when they have not yet been enabled but someone chooses their status page. Why not make Captive Portal work the same.


Files

CPstatus.png (9.35 KB) CPstatus.png Phillip Davis, 11/24/2015 11:13 AM
Actions #1

Updated by Phillip Davis almost 6 years ago

Add screenshot of Status->Captive Portal when there are no Zones defined.

Actions #2

Updated by Steve Beaver almost 6 years ago

  • Status changed from New to Feedback
  • Assignee set to Phillip Davis

Made a separate panel when no zones are defined. Displays a warning message with a link to where a user can add zones.

Actions #3

Updated by Steve Beaver almost 6 years ago

  • % Done changed from 0 to 100
Actions #4

Updated by Phillip Davis almost 6 years ago

Special code that was removing Status->Captive Portal from the dropdown menu has been removed by https://github.com/pfsense/pfsense/commit/925817a773e62dd98863a1f93ff7feaf5a24faa4

This seems good now.

Actions #5

Updated by Chris Buechler almost 6 years ago

  • Status changed from Feedback to Resolved

all good

Actions

Also available in: Atom PDF