Feature #5608
closed
Clicking on widget name does not open widget function
90%
Description
On versions prior to 2.3 clicking on widget name would open widget function. For example, if clicked on IPsec widget name, it would automatically open IPsec status. Same with OpenVPN.
I'd suggest you return that feature or provide a icon next to the widget name.
Files
Updated by Anonymous over 8 years ago
- Status changed from New to Feedback
So clicking the widget name would have the same effect as clicking the '+' icon?
Updated by Ivor Kreso over 8 years ago
Not sure if you understood me. On 2.2+ if you click on widget name (so not from the widget list, but when you add the widget) it will open the status or options for that widget. Let me know if you need me to provide more info.
Updated by Anonymous over 8 years ago
Which is the same thing that happens when you click the '+' sign to the far right of the widget name (in the title bar) right?
Updated by Ivor Kreso over 8 years ago
Are you talking about this ? https://i.imgur.com/0pt7bbp.png
Because I'm talking on about this, where there is no + sign on the widget https://i.imgur.com/VpXk3oM.png
Updated by Anonymous over 8 years ago
Because in your example the widget is already open, so it show a minus sign rather than a plus sign.
Updated by Ivor Kreso over 8 years ago
Click on + sign while it's being closed / minimized only opens the widget, it doesn't go to status or function. I think that's what confusing you. When the widget is open, when you click on widget name, for example on IPsec it goes to IPsec status page. Same happens with OpenVPN, CARP and other widgets. It opens an additional function.
Updated by Phillip Davis over 8 years ago
- File Dashboard225.png Dashboard225.png added
Here is a 2.2.5 dashboard screen shot. "Gateways" is underlined. When you click it, you are taken to status_gateways. Similar for most widgets.
Updated by Anonymous over 8 years ago
Ah. "Open the widget function" doesn't exactly convey that. So you want to open the status page that is related to the widget, where applicable. The architecture of the dashboard may make that something of a challenge, but I'll take a look.
Updated by Ivor Kreso over 8 years ago
Yes, that's it. Glad we're on the same page now. That was functional on versions prior to 2.3, a lot of people are used to it I suppose. It's quite convenient.
Updated by Anonymous over 8 years ago
Added as requested.
JDillard will refine link styling
Updated by Ivor Kreso over 8 years ago
- % Done changed from 0 to 90
This is now working flawlessly, should we close this ticket?
Updated by Phillip Davis over 8 years ago
Not quite flawless - I noticed that Dynamic DNS Status widget does not have a link. That is because the displayed name of the widget is "Dynamic DNS Status" but the underlying file names and var names for this widget are based on dyn_dns_status.
https://github.com/pfsense/pfsense/pull/2197
This makes the code simpler and based on the underlying file name that the widget uses, rather than the displayed name.
Updated by Phillip Davis over 8 years ago
Also https://github.com/pfsense/pfsense/pull/2198 eliminates the need to generate the widget title text by auto-capitalization and a loop of special cases.
I think this is all working now - until the next special case is found :)
Updated by Anonymous over 8 years ago
Agreed. I was about to address exactly this but you beat me to it :) Thanks.
Updated by Anonymous over 8 years ago
- Status changed from Feedback to Assigned
- Assignee set to Jared Dillard
Need to style the linked titles (probably white, underlined on pfSense.css). The default blue link color is not so good on a gray title bar.
Updated by Anonymous about 8 years ago
- Status changed from Assigned to Closed
Completed as requested