Project

General

Profile

Actions

Bug #5651

closed

Can't edit DHCP static mappings

Added by Jacob Graf almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
12/17/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

When trying to add a static IP assignment under DHCP server, you get an error "The IP address must lie in the LAN subnet." even though the IP that was entered is indeed within the subnet and is also outside of the DHCP scope. Previous entries that were created under a prior version can no longer be edited due to the same error.

Actions #1

Updated by Phillip Davis almost 6 years ago

What pfSense version?
I don't see that problem. Please give an example of the LAN subnet/mask, DHCP scope and the particular static IP address you are trying.

Actions #2

Updated by Chris Buechler almost 6 years ago

  • Subject changed from The IP address must lie in the LAN subnet error to Can't edit DHCP static mappings
  • Category set to Web Interface
  • Status changed from New to Confirmed
  • Target version set to 2.3
  • Affected Version set to 2.3

I see the issue, if you edit an existing static mapping on 2.3, it fails input validation.

Actions #3

Updated by Chris Buechler almost 6 years ago

  • Assignee set to Steve Beaver
Actions #4

Updated by Phillip Davis almost 6 years ago

PR https://github.com/pfsense/pfsense/pull/2292 should fix this.
I also added checks to stop people using the network address or broadcast address - I can't think of a use case where those would be valid as DHCP static mapped addresses.

This is a similar problem to https://redmine.pfsense.org/issues/5654

Actions #5

Updated by Steve Beaver almost 6 years ago

  • Status changed from Confirmed to Feedback
  • Assignee changed from Steve Beaver to Jacob Graf

Committed above PR and tested.

Actions #6

Updated by Chris Buechler almost 6 years ago

  • Status changed from Feedback to Resolved

fixed

Actions

Also available in: Atom PDF