Bug #5710
closedfirewall_nat_edit.php target custom port field not grayed out where should be
100%
Description
On firewall_nat_edit.php, the custom port box for "Redirect target port" doesn't get grayed out when an option is chosen from the drop down. It should behave the same as "Source port range" and "Destination port range" on that page - if something is picked from the drop down (say, HTTP), then the Custom box gets grayed out.
This snippet looks like it's trying to do that.
if (($('#localbeginport').find(":selected").index() == 0) && portsenabled) { disableInput('localbeginport_cust', false); } else { $('#localbeginport_cust').val(''); disableInput('localbeginport_cust', true); }
but it doesn't actually disable/enable the field.
Updated by Anonymous almost 9 years ago
- Status changed from Confirmed to Feedback
- Assignee changed from Anonymous to Chris Buechler
2.2.x seems to behave the same way. The reason is that although the Javascript does disable this control, it is immediately re-enabled by code based on the protocol.
I have commented out that piece for now. I'm pretty sure there should be no unwanted side effects and that this makes the page operate correctly.
Updated by Anonymous almost 9 years ago
- % Done changed from 0 to 100
Applied in changeset 1311f25eef75df6387ee5cf6c9b45bb251b7666f.