Project

General

Profile

Actions

Bug #5722

closed

services_dhcp pool and static mapping validations

Added by Phillip Davis over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
DHCP (IPv4)
Target version:
-
Start date:
01/01/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

This is part of https://redmine.pfsense.org/issues/5720 items 3 and 4 plus other validation issues that I found.

1) When adding or editing pools the pool range is not being checked to see if any existing static mapping falls within the pool range. This is because $a_maps[] array was not getting setup when processing pool add/edit.

2) If you add a pool that completely covers the ordinary DHCP range for an interface, that passes validation because the existing code only checks if the start or end of the pool is in the ordinary DHCP range. e.g. ordinary DHCP range is 192.168.1.30 to 192.168.1.50 then add a pool 192.168.1.20 to 192.168.1.60 - passes validation when it should not.

3) If you add/edit a pool that completely covers the range of another pool, that passes validation because the existing code only checks if the start or end of the added/edited pool is in the range of the other pool. This is a similar problem to item (2).

4) If you try to define an ordinary DHCP range or a pool that starts or ends at an existing static mapping entry IP address, then it passes validation when it should not.

Actions #1

Updated by Phillip Davis over 9 years ago

PR https://github.com/pfsense/pfsense/pull/2342 for RELENG_2_2
I tested in 2.2.6 and found that all these problems are there, so might as well provide the fix for that, even if 2.2.7 never happens.
I will make the equivalent for 2.3 master branch also...

Actions #2

Updated by Phillip Davis over 9 years ago

PR https://github.com/pfsense/pfsense/pull/2343 for master to fix the same 4 items.

Actions #3

Updated by Anonymous over 9 years ago

  • Status changed from New to Feedback

Merged in master

Thanks

Actions #4

Updated by Phillip Davis over 9 years ago

Steve, 2343 still looks open and I see no commit to master.

Actions #5

Updated by Renato Botelho over 9 years ago

Merged now, thanks!

Actions #6

Updated by Anonymous over 9 years ago

  • Status changed from Feedback to Resolved
  • Assignee deleted (Phillip Davis)
Actions

Also available in: Atom PDF