Project

General

Profile

Actions

Todo #5789

closed

Convert Form_Select option names to gettext translated strings

Todo #5789: Convert Form_Select option names to gettext translated strings

Added by Anonymous over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/21/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:

Description

Unless we have a better idea, certain Form_Select arguments will need to have gettext applied before being passed to the class. This is to facilitate "static" string extraction with xgettext

e.g.:

Form_Select(
'color'
'Shirt color',
array('red' => 'Scarlet', 'blue' => 'Sky Blue')
$pconfig['color']
);

will need to become:

Form_Select(
'color'
'Shirt color',
array('red' => gettext('Scarlet'), 'blue' => gettext('Sky Blue'))
$pconfig['color']
);

Updated by Anonymous over 10 years ago Actions #1

  • Tracker changed from Bug to Todo

PD Updated by Phillip Davis over 10 years ago Actions #2

I am currently going through the code for places in general that are missing gettext() - so I am happy to make the updates for this as I go.

I guess you already have a way for xgettext to understand that 'Shirt color' is a string that needs translation.

Updated by Anonymous over 10 years ago Actions #3

  • % Done changed from 0 to 40

Updated by Anonymous over 10 years ago Actions #4

  • Status changed from Assigned to Feedback
  • % Done changed from 40 to 100
  • Affected Architecture All added
  • Affected Architecture deleted ()

All files updated and tested where appropriate

Updated by Anonymous over 10 years ago Actions #5

Applied in changeset commit:b50d30c3a6d29b02cc7f4fe66f3a16bc7a4ea1a6.

Updated by Anonymous over 10 years ago Actions #6

  • Status changed from Feedback to Resolved
  • Assignee deleted (Anonymous)
Actions

Also available in: Atom