Project

General

Profile

Actions

Todo #5789

closed

Convert Form_Select option names to gettext translated strings

Added by Steve Beaver almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
01/21/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:

Description

Unless we have a better idea, certain Form_Select arguments will need to have gettext applied before being passed to the class. This is to facilitate "static" string extraction with xgettext

e.g.:

Form_Select(
'color'
'Shirt color',
array('red' => 'Scarlet', 'blue' => 'Sky Blue')
$pconfig['color']
);

will need to become:

Form_Select(
'color'
'Shirt color',
array('red' => gettext('Scarlet'), 'blue' => gettext('Sky Blue'))
$pconfig['color']
);

Actions #1

Updated by Steve Beaver almost 6 years ago

  • Tracker changed from Bug to Todo
Actions #2

Updated by Phillip Davis almost 6 years ago

I am currently going through the code for places in general that are missing gettext() - so I am happy to make the updates for this as I go.

I guess you already have a way for xgettext to understand that 'Shirt color' is a string that needs translation.

Actions #3

Updated by Steve Beaver almost 6 years ago

  • % Done changed from 0 to 40
Actions #4

Updated by Steve Beaver almost 6 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 40 to 100
  • Affected Architecture All added
  • Affected Architecture deleted ()

All files updated and tested where appropriate

Actions #6

Updated by Steve Beaver almost 6 years ago

  • Status changed from Feedback to Resolved
  • Assignee deleted (Steve Beaver)
Actions

Also available in: Atom PDF