pfSense

On three systems I have seen an error during the reboot process in upgrade_142_to_143() when run from rc.bootup. Stack trace is:

[10-Feb-2016 08:31:20 America/New_York] PHP Stack trace:
[10-Feb-2016 08:31:20 America/New_York] PHP   1. {main}() /etc/rc.bootup:0
[10-Feb-2016 08:31:20 America/New_York] PHP   2. convert_config() /etc/rc.bootup:197
[10-Feb-2016 08:31:20 America/New_York] PHP   3. upgrade_142_to_143() /etc/inc/config.lib.inc:456

Though it does seem to convert the configuration OK if it happens when the system is up already (gitsync or run manually). Looks like at a minimum that function needs some is_array() tests on the vars before attempting a foreach.

Assigning to Steve B since the function is handling rule separator entries.