Project

General

Profile

Bug #6010

interfaces_gre.php: Interface flags on GRE interfaces are incorrectly configured, always enabled when saving in GUI

Added by Jim Pingle about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Interfaces
Target version:
Start date:
03/18/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

When creating or editing a GRE interface the interface at the OS level (e.g. gre0) has all flags by default (LINK0, LINK1, LINK2) despite the GUI settings showing them disabled. Checking the boxes and saving has no effect.

When booting, the flags appear to be processed correctly.

Issue seems to be present on 2.2.x and 2.3.

I have a fix, will push momentarily.

Associated revisions

Revision 93520d92 (diff)
Added by Jim Pingle about 3 years ago

Correct the code saving values for GRE. The GRE configure backend code tests for isset, the way the values were copied before it would be set to 'false' which was still set, so the code always triggered when it shouldn't. When reading back from XML at boot time it's OK, so only the web interface is affected. Fixes #6010

Revision 7468ce30 (diff)
Added by Jim Pingle about 3 years ago

GIF had the same problem as GRE with flags, apply the same fix. Ticket #6010

History

#1 Updated by Jim Pingle about 3 years ago

gif had the same problem, pushed a fix for both.

#2 Updated by Jim Pingle about 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Renato Botelho about 3 years ago

  • Status changed from Feedback to Resolved

Works

Also available in: Atom PDF