Project

General

Profile

Bug #6027

Captive portal 404 log spam

Added by Orsiris de Jong over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Very Low
Category:
Captive Portal
Target version:
Start date:
03/25/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Hello,

Minor bug here, when opening the captive portal, there's no favicon.ico so nginx complains:

nginx: 2016/03/25 11:53:39 [error] 10501#0: *6 open() "/usr/local/captiveportal/favicon.ico" failed (2: No such file or directory), client: 172.16.1.70, server: , request: "GET /favicon.ico HTTP/1.1", host: "172.16.1.1:8002"

As uploading files rename all files to captiveportal-[filename], this can't be solved via GUI.
I indeed uploaded a favicon.ico to /usr/local/captiveportal which fixed the error message.

What about putting a default favicon.ico there ?
Or a gui option to not rename a file if it's called favicon.ico ? I'd be glad to make a PR on git.

Regards,
Ozy.

Associated revisions

Revision 2f004405 (diff)
Added by Chris Buechler over 3 years ago

Don't log 404s for captive portal. Ticket #6027

History

#1 Updated by Chris Buechler over 3 years ago

  • Subject changed from Captive portal missing favicon to Captive portal 404 log spam
  • Status changed from New to Resolved
  • Assignee set to Chris Buechler
  • Target version set to 2.3

It's never had one, lighttpd just didn't log 404s there where nginx does. Turning this ticket into that issue since that'll just generate unnecessary log spam.

I just pushed a change to disable 404 logging for captive portal.

I don't think a favicon is important to accommodate. Those who want one can manually upload it. But I'd be fine with not renaming favicon.ico files uploaded to the CP file manager. If you'd like to submit a PR for that, we can get that merged post-2.3.

#2 Updated by Orsiris de Jong over 3 years ago

Great, no more 404 error logs! PR #2799 created :)

#3 Updated by Jose Luis Duran over 3 years ago

What you can do is, in the head of your custom captive portal page, add:

<link rel="icon" href="captiveportal-favicon.ico">

Also available in: Atom PDF