Project

General

Profile

Bug #6327

Alignment defect in forms

Added by Frederic Lietart over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Web Interface
Target version:
Start date:
05/06/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Hi,

I have a small general misalignment in forms (see attachments)

  • Current Base System 2.3.1.a.20160505.1243
  • Firefox 46.0.1
align1.png (7.79 KB) align1.png Frederic Lietart, 05/06/2016 04:01 PM
align2.png (22.9 KB) align2.png Frederic Lietart, 05/06/2016 04:01 PM

Associated revisions

Revision 54fc9503 (diff)
Added by Steve Beaver over 3 years ago

Experimentally fixed #6327

Revision f2c719c9 (diff)
Added by Steve Beaver over 3 years ago

Experimentally fixed #6327

(cherry picked from commit 54fc9503ff550d04d1253c41c1fd49da1b64c07e)

History

#1 Updated by Frederic Lietart over 3 years ago

Hi,

Same problem on 2.3_1 - Tested on Safari

Thx

#2 Updated by Steve Beaver over 3 years ago

This particularly affects instances of the Form_Statictext() class but can be seen elsewhere as shown here. It affects all browsers.

I'll looks at this as time permits, probably in the next few days.

#3 Updated by Steve Beaver over 3 years ago

  • Assignee set to Steve Beaver
  • Target version set to 2.3.1

#4 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Frederic Lietart

I have added some top padding to revise the vertical alignment but marked it as "experimental". If no anomalies arise I'll make it permanent.

#5 Updated by Steve Beaver over 3 years ago

  • % Done changed from 0 to 100

#6 Updated by Frederic Lietart over 3 years ago

There's more, but I'm afraid of change ".col-sm-10" breaks the overall style, especially in the additional packages

#7 Updated by Steve Beaver over 3 years ago

It may, but lets see how this turns out while I research other possibilities.

#8 Updated by Frederic Lietart over 3 years ago

it remains the checkbox that are not aligned for me :)

#9 Updated by Frederic Lietart over 3 years ago

Your change break my PR https://github.com/pfsense/pfsense/pull/2940 :) which can be replaced by your fix

#10 Updated by Steve Beaver over 3 years ago

Thanks for your fix. It was effective but I realized that it could be applied in a way that fixed alignment issues in several other places :)

#11 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

looks good, thanks!

Also available in: Atom PDF