Project

General

Profile

Bug #6732

interfaces_ppps_edit.php: L2TP and PPTP WAN-type interface editing has broken input validation

Added by Jim Pingle 9 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Interfaces
Target version:
Start date:
08/19/2016
Due date:
% Done:

100%

Affected version:
2.3.2
Affected Architecture:

Description

On interfaces_ppps_edit.php when an L2TP or PPTP interface is created or edited, it cannot be saved.

Both types have an expanding list of "IP/Gateway" inputs for each selected interface, but input validation is not checking the arrays properly and it is rejecting any input. When the input validation is removed, the values are not stored in the config either.

Going the other way seems to work, starting at interfaces.php and then making an L2TP interface there, it works. If you edit that working entry at interfaces_ppps_edit.php it shows the values entered on the other page, but on save they are lost, as above.

Associated revisions

Revision 9db8959d
Added by Steve Beaver 9 months ago

Fixed #6732

(cherry picked from commit e73770057872aa1f78dfff885f89916e446e2e4c)

History

#1 Updated by Steve Beaver 9 months ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to Jim Pingle

Element names and validation code fixed to resolve issue.

localip, submnt, gateway, mtu, mru & mrru tested

#2 Updated by Steve Beaver 9 months ago

  • % Done changed from 0 to 100

#3 Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved

Looks good now

#4 Updated by Jim Pingle 3 months ago

  • Target version changed from 2.4.0 to 2.3.3

#5 Updated by Thomas Rieschl 2 months ago

It seems that it only works partially.
I just tried to paly around with the interfaces_ppps_edit.php-Settings on version 2.4.0-BETA-amd64-20170309. The values seem to get saved but are not displayed in the input fields when opening the page.
It's the same behavior in version 2.3.3-p1 btw.

#6 Updated by Phillip Davis 2 months ago

Can you give some detail of what you are entering. I can't (easily) reproduce it, so maybe there is some unusual/specific set of inputs that are a problem.

Also available in: Atom PDF