Project

General

Profile

Bug #6801

Rule separators are moving when multiple firewall rules are deleted together

Added by TCI User about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
09/21/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3.2
Affected Architecture:
amd64

Description

Steps to reproduce:

1. Select multiple firewall rules
2. Delete together
3. The rule separators changed their position

IMPORTANT NOTE: Only the separators below the deleted firewall rules are moving.

A1.jpg (117 KB) A1.jpg Select multiple firewall rules and delete together TCI User, 09/21/2016 08:27 AM
A2.jpg (90.8 KB) A2.jpg The rule separators changed their position TCI User, 09/21/2016 08:27 AM

Associated revisions

Revision 83b4b514 (diff)
Added by Steve Beaver about 3 years ago

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

Revision 7dd9db77 (diff)
Added by Steve Beaver about 3 years ago

Fixed #6801

(cherry picked from commit 00098bc80b6f85eb74f2f3bc2b4eb7430614110d)

History

#1 Updated by Steve Beaver about 3 years ago

  • Assignee set to Steve Beaver

#2 Updated by Steve Beaver about 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to TCI User

Fixed and tested. Please confirm.

#3 Updated by Steve Beaver about 3 years ago

  • % Done changed from 0 to 100

#4 Updated by TCI User about 3 years ago

Steve Beaver wrote:

Applied in changeset 00098bc80b6f85eb74f2f3bc2b4eb7430614110d.

Steve, would you provide me with basic instructions on how to apply the change so I can test it?

I already have the System_Patches package installed.

Thanks,
Slav

#5 Updated by Steve Beaver about 3 years ago

Probably easiest to just wait from the next snapshot and update. Alternatively you could access the updated file here: https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/firewall_rules.php and copy/paste it into your pfSense installation using Diagnostics -> Edit file.

#6 Updated by Jim Pingle about 3 years ago

The wiki doc for the System Patches package explains how to use the commit ID from the above comment to apply the patch: https://doc.pfsense.org/index.php/System_Patches

#7 Updated by TCI User about 3 years ago

Thank you Steve / Jim.

I found it safer to apply the changes through Diagnostics -> Edit file.

Confirming that firewall_rules.php works fine and the separators do not move.

Please apply the change and to firewall_nat.php

Regards,
Slav

#8 Updated by Steve Beaver about 3 years ago

  • Status changed from Feedback to Resolved
  • Target version set to 2.3.2-p1

Thanks for confirming. Fix has now been applied to firewall_nat.php as well.

Also available in: Atom PDF