Project

General

Profile

Bug #9887

Rule separator positions change when deleting multiple rules

Added by Jim Pingle over 1 year ago. Updated 3 days ago.

Status:
Feedback
Priority:
Low
Assignee:
Category:
Rules / NAT
Target version:
Start date:
11/07/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

When deleting rules around a separator at the end of the ruleset, separator positions can change unintentionally. Similar to #6801 but doesn't appear to be identical.

I was only able to reproduce it when removing the last few rules of an interface ruleset. If I deleted single rules or multiples around/between higher separator bars, there was no issue and things stayed in the expected places.

See attached before/after photos to see how to reproduce it.

sep-test2-after.jpg (123 KB) sep-test2-after.jpg Test #2 - After Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test2-before.jpg (157 KB) sep-test2-before.jpg Test #2 - Before Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test1-before.jpg (159 KB) sep-test1-before.jpg Test #1 - Before Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test1-after.jpg (137 KB) sep-test1-after.jpg Test #1 - After Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test2-after.JPG (28.8 KB) sep-test2-after.JPG Dan Mackie, 12/17/2020 02:19 AM
sep-test2-before.jpg (37.9 KB) sep-test2-before.jpg Dan Mackie, 12/17/2020 02:19 AM
sep-test1-after.JPG (31.2 KB) sep-test1-after.JPG Dan Mackie, 12/17/2020 02:19 AM
sep-test1-before.jpg (38.1 KB) sep-test1-before.jpg Dan Mackie, 12/17/2020 02:19 AM
sep-test4-after.JPG (47.1 KB) sep-test4-after.JPG Dan Mackie, 12/17/2020 04:26 AM
sep-test4-before.JPG (57.5 KB) sep-test4-before.JPG Dan Mackie, 12/17/2020 04:26 AM
sep-test3-after.JPG (72.5 KB) sep-test3-after.JPG Test for #6801 - After Dan Mackie, 12/17/2020 04:26 AM
sep-test3-before.JPG (91.1 KB) sep-test3-before.JPG Test for #6801 - Before Dan Mackie, 12/17/2020 04:26 AM

Associated revisions

Revision 3e7a04be (diff)
Added by Dan Mackie 2 months ago

Fix separators moving when multiple deleted - Fix #9887

Revision deec78dc (diff)
Added by Dan Mackie 2 months ago

Fix separators moving when multiple deleted - Fix #9887 and #6801

History

#1 Updated by Steve Beaver 5 months ago

  • Assignee set to Steve Beaver

#2 Updated by Steve Beaver 5 months ago

  • Priority changed from Normal to Low

#3 Updated by Steve Beaver 4 months ago

  • Target version changed from 2.5.0 to CE-Next

#5 Updated by Dan Mackie 2 months ago

PR: https://github.com/pfsense/pfsense/pull/4491

Fix allows both Jim Pingle's screenshots from this issue and those in #6801 to work as expected.

Note - If possible, delete the images from comment No. 4 above as they are before I realised I had not actually fixed the issue correctly.

#6 Updated by Renato Botelho 4 days ago

  • Status changed from New to Feedback

PR has been merged. Thanks!

#7 Updated by Dan Mackie 3 days ago

  • % Done changed from 0 to 100

Also available in: Atom PDF