Project

General

Profile

Actions

Bug #9887

open

Rule separator positions change when deleting multiple rules

Added by Jim Pingle almost 2 years ago. Updated about 2 months ago.

Status:
New
Priority:
Low
Assignee:
Category:
Rules / NAT
Target version:
Start date:
11/07/2019
Due date:
% Done:

50%

Estimated time:
Plus Target Version:
22.01
Release Notes:
Default
Affected Version:
All
Affected Architecture:
All

Description

When deleting rules around a separator at the end of the ruleset, separator positions can change unintentionally. Similar to #6801 but doesn't appear to be identical.

I was only able to reproduce it when removing the last few rules of an interface ruleset. If I deleted single rules or multiples around/between higher separator bars, there was no issue and things stayed in the expected places.

See attached before/after photos to see how to reproduce it.


Files

sep-test2-after.jpg (123 KB) sep-test2-after.jpg Test #2 - After Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test2-before.jpg (157 KB) sep-test2-before.jpg Test #2 - Before Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test1-before.jpg (159 KB) sep-test1-before.jpg Test #1 - Before Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test1-after.jpg (137 KB) sep-test1-after.jpg Test #1 - After Delete Jim Pingle, 11/07/2019 09:46 AM
sep-test2-after.JPG (28.8 KB) sep-test2-after.JPG Dan Mackie, 12/17/2020 02:19 AM
sep-test2-before.jpg (37.9 KB) sep-test2-before.jpg Dan Mackie, 12/17/2020 02:19 AM
sep-test1-after.JPG (31.2 KB) sep-test1-after.JPG Dan Mackie, 12/17/2020 02:19 AM
sep-test1-before.jpg (38.1 KB) sep-test1-before.jpg Dan Mackie, 12/17/2020 02:19 AM
sep-test4-after.JPG (47.1 KB) sep-test4-after.JPG Dan Mackie, 12/17/2020 04:26 AM
sep-test4-before.JPG (57.5 KB) sep-test4-before.JPG Dan Mackie, 12/17/2020 04:26 AM
sep-test3-after.JPG (72.5 KB) sep-test3-after.JPG Test for #6801 - After Dan Mackie, 12/17/2020 04:26 AM
sep-test3-before.JPG (91.1 KB) sep-test3-before.JPG Test for #6801 - Before Dan Mackie, 12/17/2020 04:26 AM
Actions #1

Updated by Steve Beaver about 1 year ago

  • Assignee set to Steve Beaver
Actions #2

Updated by Steve Beaver about 1 year ago

  • Priority changed from Normal to Low
Actions #3

Updated by Steve Beaver 12 months ago

  • Target version changed from 2.5.0 to CE-Next
Actions #5

Updated by Dan Mackie 10 months ago

PR: https://github.com/pfsense/pfsense/pull/4491

Fix allows both Jim Pingle's screenshots from this issue and those in #6801 to work as expected.

Note - If possible, delete the images from comment No. 4 above as they are before I realised I had not actually fixed the issue correctly.

Actions #6

Updated by Renato Botelho 8 months ago

  • Status changed from New to Feedback

PR has been merged. Thanks!

Actions #7

Updated by Dan Mackie 8 months ago

  • % Done changed from 0 to 100
Actions #8

Updated by Jim Pingle 6 months ago

  • Target version changed from CE-Next to 2.6.0
Actions #9

Updated by Jim Pingle 6 months ago

  • Plus Target Version set to 21.05
Actions #10

Updated by Jim Pingle 6 months ago

Already in 21.05 branch.

Actions #11

Updated by Jim Pingle 5 months ago

  • Status changed from Feedback to New
  • % Done changed from 100 to 50
  • Plus Target Version changed from 21.05 to 21.09

Still broken but not a blocker so moving forward. The scenario in my first test "sep-test1" is OK. The second scenario "sep-test2" still breaks. The behavior is different, however, as now the second separator "Sep 2" has moved to the top of the interface rules instead of staying at the bottom.

Actions #12

Updated by Jim Pingle about 2 months ago

  • Plus Target Version changed from 21.09 to 22.01

Moving ahead

Actions

Also available in: Atom PDF