Project

General

Profile

Bug #6893

Configuration XML is inconsistent with self closing tags

Added by Kevin Wojniak 6 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Backup/restore
Target version:
Start date:
11/04/2016
Due date:
% Done:

100%

Affected version:
2.3.x
Affected Architecture:

Description

Whenever I make changes I do "Download configuration as XML" and store the file in a git repository, so I always view the diff of what's changed. Very often, tags that are empty don't always generate the same output.

For example, the <shaper> element was:

<shaper>
</shaper>

but now it's:

<shaper/>

config_diff.png (114 KB) Kevin Wojniak, 11/04/2016 10:14 AM

Associated revisions

Revision da7054b7
Added by Steve Beaver 6 months ago

Fixed #6893
Null configuration settings are now written as <tag></tag> instead of <tag /> for consistency

Revision e5f9360f
Added by Steve Beaver 6 months ago

Fixed #6893
Null configuration settings are now written as <tag></tag> instead of <tag /> for consistency

History

#1 Updated by Kevin Wojniak 6 months ago

Here's another example. I only deleted some L2TP users, but the XML has changed for these values (screenshot from SourceTree).

#2 Updated by Jim Thompson 6 months ago

  • Assignee set to Steve Beaver

#3 Updated by Steve Beaver 6 months ago

  • Status changed from New to Feedback

Null configuration settings are now written as <tag></tag> instead of <tag /> for consistency

#4 Updated by Steve Beaver 6 months ago

  • % Done changed from 0 to 100

#5 Updated by Kevin Wojniak 6 months ago

Awesome, thanks for the quick fix!

#6 Updated by Steve Beaver 6 months ago

  • Status changed from Feedback to Resolved

#7 Updated by Jim Pingle 3 months ago

  • Target version set to 2.3.3

Also available in: Atom PDF