Project

General

Profile

Actions
Copy link

Bug #6984

closed
KB KB

NTP/ACLs - Delete button partially invisible + rowhelper handling broken

Bug #6984: NTP/ACLs - Delete button partially invisible + rowhelper handling broken

Added by Kill Bill almost 10 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Kill Bill
Category:
Web Interface
Target version:
2.3.3
Start date:
12/05/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.x
Affected Architecture:
All

Description

Beyond #6454 (still unfixed), there are other issues with this thing, such as:
- the button not fitting the page

- the page seemingly won't let you delete the first row, however when you add a couple of rows and then delete them (e.g., click "Add" twice, then "Delete" twice), you get the following WTF:

KB Updated by Kill Bill almost 10 years ago Actions
Copy link
 #1

Playing with Delete is apparently lot of fun, also managed to produce this result:

And after a while, the wonderful "Are you sure you wish to?" prompt mentioned in #6972 shown up as well.

Updated by Anonymous almost 10 years ago Actions
Copy link
 #2

  • Status changed from New to Feedback
  • Assignee set to Kill Bill

Both issues fixed in JavaScript

Updated by Anonymous almost 10 years ago Actions
Copy link
 #3

  • % Done changed from 0 to 100

Applied in changeset commit:3b1c0951ddb913cefcf3aaca301c9a8803a50224.

KB Updated by Kill Bill almost 10 years ago Actions
Copy link
 #4

OK... The button now almost fits, plus the issues on the second and third screenshots seem to be indeed fixed.

Other than that:
- The button randomly fails to produce any action, sometimes it becomes really stubborn and requires tens of clicks to get back to action.
- Still getting that "Are you sure you wish to?" prompt randomly.

I guess we can keep those for #6972. Thanks.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved

Seems fine now, the behavior is correct and the button has space around it.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #6

  • Target version changed from 2.4.0 to 2.3.3

KB Updated by Kill Bill over 9 years ago Actions
Copy link
 #7

This still has broken behaviour (to see Delete, you need to click Add), plus the whole thing needs backport to 2.3.x

https://forum.pfsense.org/index.php?topic=129011.msg710824#msg710824

Actions
Copy link

Also available in: Atom