Project

General

Profile

Bug #7185

DHCP6c SIGTERM, SIGKILL

Added by Martin Wasley 6 months ago. Updated 4 months ago.

Status:
Feedback
Priority:
High
Assignee:
Category:
DHCP6
Target version:
Start date:
02/01/2017
Due date:
% Done:

0%

Affected version:
All
Affected Architecture:
All

Description

I have found that when issuing a SIGTERM to dhcp6c that it immediately deletes the pid file, however, if the WAN interface is down then it will continue to send release signals for at least thirty seconds. The issue here is that the call to kill the process checks to see if the process is still alive before issuing a final sigkill, as the pid has been deleted that sigkill does not get sent as dhcp6c continues on.

I have issued an UPSTREAM PR to correct this along with some additions.

History

#1 Updated by Luke Hamburg 6 months ago

Martin, could you provide a link to the PR?

#2 Updated by Martin Wasley 6 months ago

You cannot patch it Luke, it's an exe. I can send it to you when I am back at my desk.

#3 Updated by Luke Hamburg 6 months ago

Thank you very much. I am testing these now. I got the binaries scp'd onto the test box. I moved the stock binaries to /root/orig/ then ran chmod 555 dhcp6* on the replacements, since the old binaries were set r-xr-xr-x. After that, I applied the 417f208188be97c0fb9edf800d8e9aa2fe61d174 patch and rebooted. Everything is up and running as of now, also updated to latest snap 2.4.0.b.20170202.1158

I had the stock dhcp6c fail on me earlier tonight after a brief 7 minute WAN2 outage. WAN2 came back up but DHCP6 Gateway status was "Unknown" on Dashboard as well as Status > Gateways. I checked from console and there was only 1 dhcp6c process running (which was an improvement over the 2.3.2_p1 behavior where I would often wind up with 3 copies of the daemon!) But still, something was amiss.

So if this fixes things, it would be very timely. Will report back. cheers

#4 Updated by Luke Hamburg 6 months ago

Patch is working well so far!

I think possibly #6944 and #7145 should be merged into this ticket?

#5 Updated by Martin Wasley 6 months ago

Yes, they are both 'hopefully' put to sleep with the changes done in the script patch I sent you and with dhcp6c changes. My testers are just going through a few final revisions - changed the logging a bit and introduced another new signal, that's for future use with the lease release button that's appeared.

I'll send you the latest revision to play with, hopefully I can issue a PR Monday or Tuesday on this if none of the testers come back with any negatives.

New stuff will be in your inbox shortly.

#6 Updated by Martin Wasley 4 months ago

Close this Issue. DHCP6C has been fixed.

#7 Updated by Jim Pingle 4 months ago

  • Category set to DHCP6
  • Status changed from New to Feedback
  • Assignee set to Martin Wasley
  • Target version set to 2.4.0
  • Affected Architecture set to All

Also available in: Atom PDF