Project

General

Profile

Actions

Bug #7379

closed

Virtual IPs/Proxy ARP: Not defined pid file on starting choparp.

Added by aLexander Panfilov about 7 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Virtual IP Addresses
Target version:
Start date:
03/12/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.5-p1
Affected Architecture:

Description

Not defined pid file on starting choparp. The pfSense may not kill the program to reconfiguration.

--- interfaces.inc.orig 2017-03-12 18:56:36.471976000 +0300
+++ interfaces.inc 2017-03-12 19:32:14.875358000 +0300
@ -2248,7 +2248,9 @
if (!is_ipaddr($paaifip)) {
return;
}
- $args = get_real_interface($interface) . " auto";
+ $vipif = get_real_interface($interface);
+ $args = "-p {$g['varrun_path']}/choparp_{$vipif}.pid ";
+ $args .= $vipif . " auto";
foreach ($paa[$interface] as $paent) {
if (isset($paent['subnet'])) {
$args .= " " . escapeshellarg("{$paent['subnet']}/{$paent['subnet_bits']}");
@ -2264,7 +2266,9 @
if (!is_ipaddr($paaifip)) {
continue;
}
- $args = get_real_interface($paif) . " auto";
+ $vipif = get_real_interface($interface);
+ $args = "-p {$g['varrun_path']}/choparp_{$vipif}.pid ";
+ $args .= $vipif . " auto";
foreach ($paents as $paent) {
if (isset($paent['subnet'])) {
$args .= " " . escapeshellarg("{$paent['subnet']}/{$paent['subnet_bits']}");

Actions #1

Updated by aLexander Panfilov about 7 years ago

New Bug after applying the patch:
There are several PoxyARP VIPs. Open one of them to edit and change the type to an Alias or Another (CARP not checked). choparp is dying, but not starting again.

Helps:
Open to edit any ProxyARP VIP and save unchanged. choparp start successfully.

Actions #2

Updated by Kill Bill about 7 years ago

Yeah, it'd help to determine what's the actual bug before attempting to fix it.

P.S. Please, use GitHub for patches: https://github.com/pfsense/pfsense

Actions #3

Updated by Jim Pingle over 4 years ago

  • Category set to Virtual IP Addresses
Actions #4

Updated by Viktor Gurov over 3 years ago

aLexander Panfilov wrote:

New Bug after applying the patch:
There are several PoxyARP VIPs. Open one of them to edit and change the type to an Alias or Another (CARP not checked). choparp is dying, but not starting again.

Helps:
Open to edit any ProxyARP VIP and save unchanged. choparp start successfully.

Fix:
https://github.com/pfsense/pfsense/pull/4417

Actions #5

Updated by Jim Pingle over 3 years ago

  • Status changed from New to Pull Request Review
  • Target version set to 2.5.0
Actions #6

Updated by Renato Botelho over 3 years ago

  • Status changed from Pull Request Review to Feedback
  • Assignee set to Renato Botelho
  • % Done changed from 0 to 100

PR has been merged. Thanks!

Actions #7

Updated by Viktor Gurov over 3 years ago

  • Status changed from Feedback to Resolved
  • Affected Version set to 2.4.5-p1

works as expected on 2.5.0.a.20200916.1850
choparp is restarted on vip change

Actions

Also available in: Atom PDF