Bug #7379
closedVirtual IPs/Proxy ARP: Not defined pid file on starting choparp.
100%
Description
Not defined pid file on starting choparp. The pfSense may not kill the program to reconfiguration.
--- interfaces.inc.orig 2017-03-12 18:56:36.471976000 +0300
@ -2248,7 +2248,9
+++ interfaces.inc 2017-03-12 19:32:14.875358000 +0300@
@ -2264,7 +2266,9
if (!is_ipaddr($paaifip)) {
return;
}
- $args = get_real_interface($interface) . " auto";
+ $vipif = get_real_interface($interface);
+ $args = "-p {$g['varrun_path']}/choparp_{$vipif}.pid ";
+ $args .= $vipif . " auto";
foreach ($paa[$interface] as $paent) {
if (isset($paent['subnet'])) {
$args .= " " . escapeshellarg("{$paent['subnet']}/{$paent['subnet_bits']}");@
if (!is_ipaddr($paaifip)) {
continue;
}
- $args = get_real_interface($paif) . " auto";
+ $vipif = get_real_interface($interface);
+ $args = "-p {$g['varrun_path']}/choparp_{$vipif}.pid ";
+ $args .= $vipif . " auto";
foreach ($paents as $paent) {
if (isset($paent['subnet'])) {
$args .= " " . escapeshellarg("{$paent['subnet']}/{$paent['subnet_bits']}");
Updated by aLexander Panfilov over 7 years ago
New Bug after applying the patch:
There are several PoxyARP VIPs. Open one of them to edit and change the type to an Alias or Another (CARP not checked). choparp is dying, but not starting again.
Helps:
Open to edit any ProxyARP VIP and save unchanged. choparp start successfully.
Updated by Kill Bill over 7 years ago
Yeah, it'd help to determine what's the actual bug before attempting to fix it.
P.S. Please, use GitHub for patches: https://github.com/pfsense/pfsense
Updated by Viktor Gurov over 4 years ago
aLexander Panfilov wrote:
New Bug after applying the patch:
There are several PoxyARP VIPs. Open one of them to edit and change the type to an Alias or Another (CARP not checked). choparp is dying, but not starting again.Helps:
Open to edit any ProxyARP VIP and save unchanged. choparp start successfully.
Updated by Jim Pingle over 4 years ago
- Status changed from New to Pull Request Review
- Target version set to 2.5.0
Updated by Renato Botelho over 4 years ago
- Status changed from Pull Request Review to Feedback
- Assignee set to Renato Botelho
- % Done changed from 0 to 100
PR has been merged. Thanks!
Updated by Viktor Gurov about 4 years ago
- Status changed from Feedback to Resolved
- Affected Version set to 2.4.5-p1
works as expected on 2.5.0.a.20200916.1850
choparp is restarted on vip change