Project

General

Profile

Bug #7428

Rule with empty port alias causes error loading rules

Added by Phillip Davis 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules/NAT
Target version:
Start date:
03/26/2017
Due date:
% Done:

0%

Affected Version:
All
Affected Architecture:

Description

1) Create a port alias, but do not enter any ports in it (leave it empty)
2) Add a rule that uses that port alias
3) Apply
Message comes: "there were errors loading the rules"

History

#2 Updated by Jim Pingle 9 months ago

The fix looks OK to me and the PR fixes the problem, I just want to get at least one more person here to look it over due to the changes involved.

#3 Updated by Phillip Davis 9 months ago

PRs merged:
https://github.com/pfsense/pfsense/pull/3670 - code needed for fix
https://github.com/pfsense/pfsense/pull/3677 - further refactoring to tidy up some names/structure

#4 Updated by Phillip Davis 9 months ago

Tested on latest 2.4-BETA and 2.3.4-DEVELOPMENT and this is fixed. Using an empty port alias in a rule causes the rule to be skipped and a notice sent.

#5 Updated by Jim Pingle 9 months ago

  • Status changed from New to Resolved

Thanks!

Also available in: Atom PDF