Project

General

Profile

Actions
Copy link

Bug #7428

closed
PD PD

Rule with empty port alias causes error loading rules

Bug #7428: Rule with empty port alias causes error loading rules

Added by Phillip Davis over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Phillip Davis
Category:
Rules / NAT
Target version:
2.3.4
Start date:
03/26/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

1) Create a port alias, but do not enter any ports in it (leave it empty)
2) Add a rule that uses that port alias
3) Apply
Message comes: "there were errors loading the rules"

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #2

The fix looks OK to me and the PR fixes the problem, I just want to get at least one more person here to look it over due to the changes involved.

PD Updated by Phillip Davis over 9 years ago Actions
Copy link
 #3

PRs merged:
https://github.com/pfsense/pfsense/pull/3670 - code needed for fix
https://github.com/pfsense/pfsense/pull/3677 - further refactoring to tidy up some names/structure

PD Updated by Phillip Davis over 9 years ago Actions
Copy link
 #4

Tested on latest 2.4-BETA and 2.3.4-DEVELOPMENT and this is fixed. Using an empty port alias in a rule causes the rule to be skipped and a notice sent.

JP Updated by Jim Pingle over 9 years ago Actions
Copy link
 #5

  • Status changed from New to Resolved

Thanks!

Actions
Copy link

Also available in: Atom